Skip to content

[MINOR]: Standardize script name to install-spark-resources.sh#11937

Open
Yao-MR wants to merge 3 commits intoapache:mainfrom
Yao-MR:bugfix_shell-format
Open

[MINOR]: Standardize script name to install-spark-resources.sh#11937
Yao-MR wants to merge 3 commits intoapache:mainfrom
Yao-MR:bugfix_shell-format

Conversation

@Yao-MR
Copy link
Copy Markdown

@Yao-MR Yao-MR commented Apr 14, 2026

What changes are proposed in this pull request?

This change updates documentation references to use the unified script name install-spark-resources.sh consistently, replacing legacy mentions of install-resources.sh.

Why:

  • Improves naming clarity by making the script purpose explicit (Spark resource installation).
  • Prevents confusion for contributors following setup and troubleshooting guides.
  • Aligns documentation with the actual script used in build and workflow tooling.

How was this patch tested?

CI

Was this patch authored or co-authored using generative AI tooling?

No

@Yao-MR Yao-MR changed the title [MINOR][DOCS]: Standardize script name to install-spark-resources.sh [MINOR]: Standardize script name to install-spark-resources.sh Apr 14, 2026
@Yao-MR
Copy link
Copy Markdown
Author

Yao-MR commented Apr 14, 2026

Clipboard_Screenshot_1776160686

@philo-he
Copy link
Copy Markdown
Member

@Yao-MR, thanks for the PR. This script is also used to install Hadoop and Minio currently, and possibly will be used to install other resources required by CI in the future. I feel the newly proposed name may confuse developers.

@Yao-MR
Copy link
Copy Markdown
Author

Yao-MR commented Apr 15, 2026

@Yao-MR, thanks for the PR. This script is also used to install Hadoop and Minio currently, and possibly will be used to install other resources required by CI in the future. I feel the newly proposed name may confuse developers.

yes ,maybe it better to separate spark functions from other resource function, just like the correspond install-flink-resources.sh, also find some doc which name the this filename as install-spark-resources.sh

@philo-he
Copy link
Copy Markdown
Member

yes ,maybe it better to separate spark functions from other resource function, just like the correspond install-flink-resources.sh, also find some doc which name the this filename as install-spark-resources.sh

@Yao-MR, I get your point now. Actually, install-flink-resources.sh is not a proper name.

How about renaming install-resources.sh to install-spark-deps.sh, and renaming install-flink-resources.sh to install-flink-deps.sh? We may also recover install-spark-resources.sh to install spark resources only, while the installation for HDFS, MinIO, etc. goes to install-spark-deps.sh.

@Yao-MR Yao-MR force-pushed the bugfix_shell-format branch from 3ffe40c to 52a4a72 Compare April 15, 2026 08:16
@github-actions github-actions bot added the DOCS label Apr 15, 2026
… install-spark-deps.sh && install-flink-deps.sh
@Yao-MR Yao-MR force-pushed the bugfix_shell-format branch from 52a4a72 to a0beb85 Compare April 15, 2026 12:25
@github-actions github-actions bot removed the DOCS label Apr 15, 2026
@Yao-MR
Copy link
Copy Markdown
Author

Yao-MR commented Apr 15, 2026

yes ,maybe it better to separate spark functions from other resource function, just like the correspond install-flink-resources.sh, also find some doc which name the this filename as install-spark-resources.sh

@Yao-MR, I get your point now. Actually, install-flink-resources.sh is not a proper name.

How about renaming install-resources.sh to install-spark-deps.sh, and renaming install-flink-resources.sh to install-flink-deps.sh? We may also recover install-spark-resources.sh to install spark resources only, while the installation for HDFS, MinIO, etc. goes to install-spark-deps.sh.

yes, hi @philo-he have separate each function in to different shell script

  • install-flink-deps.sh for the flink dependency

  • install-spark-deps.sh for the spark dependency include hadoop,minio

  • install-spark-resources.sh for the spark

Copy link
Copy Markdown
Member

@philo-he philo-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Some comments.

Comment thread .github/workflows/velox_backend_enhanced.yml Outdated
Comment thread .github/workflows/velox_backend_enhanced.yml Outdated
Comment thread .github/workflows/velox_backend_x86.yml Outdated
Comment thread .github/workflows/velox_backend_x86.yml Outdated
Comment thread .github/workflows/velox_backend_x86.yml Outdated
Comment thread .github/workflows/velox_backend_x86.yml Outdated
Comment thread .github/workflows/util/install-spark-resources.sh
Comment thread .github/workflows/util/install-spark-resources.sh
Comment thread .github/workflows/velox_backend_x86.yml Outdated
@Yao-MR Yao-MR force-pushed the bugfix_shell-format branch from cfb2635 to 2b10ebc Compare April 16, 2026 12:17
@Yao-MR Yao-MR requested a review from philo-he April 16, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants