BugFix: SIGABRT in quantiles_sketch::deserialize(): dereferencing emp…#478
Merged
leerho merged 3 commits intoapache:masterfrom Feb 11, 2026
Merged
BugFix: SIGABRT in quantiles_sketch::deserialize(): dereferencing emp…#478leerho merged 3 commits intoapache:masterfrom
leerho merged 3 commits intoapache:masterfrom
Conversation
…ty std::optional (libc++ verbose_abort)
Pull Request Test Coverage Report for Build 21665998475Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
common/test/CMakeLists.txt
Outdated
| # Use C++17 if CMAKE_CXX_STANDARD is set to 17+, otherwise C++11 | ||
| # This allows hardening tests to use std::optional with libc++ hardening | ||
| if(DEFINED CMAKE_CXX_STANDARD) | ||
| if(CMAKE_CXX_STANDARD MATCHES "17|20|23") |
Contributor
There was a problem hiding this comment.
this seems overcomplicated
CXX_STANDARD is set to ${CMAKE_CXX_STANDARD} if defined, otherwise to 11
CXX_STANDARD_REQUIRED YES - this is set in any case
Contributor
Author
There was a problem hiding this comment.
Have updated this
AlexanderSaydakov
approved these changes
Feb 3, 2026
AlexanderSaydakov
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 477