feat: support ListView and LargeListView in ScalarValue#21669
Open
Jefffrey wants to merge 8 commits intoapache:mainfrom
Open
feat: support ListView and LargeListView in ScalarValue#21669Jefffrey wants to merge 8 commits intoapache:mainfrom
ListView and LargeListView in ScalarValue#21669Jefffrey wants to merge 8 commits intoapache:mainfrom
Conversation
github-actions
bot
added
sql
Jefffrey
commented
Apr 16, 2026
| 3, | ||
| ), | ||
| )), | ||
| ScalarValue::ListView(Arc::new(ListViewArray::from_iter_primitive::< |
Contributor
Author
There was a problem hiding this comment.
Only change in this file is adding cases for listview & largelistview; other changes is indent change. Would recommend reviewing with whitespace off
comphead
reviewed
Apr 16, 2026
Comment on lines
+3460
to
+3471
| ScalarValue::ListView(arr) => { | ||
| if size == 1 { | ||
| return Ok(Arc::clone(arr) as Arc<dyn Array>); | ||
| } | ||
| Self::list_to_array_of_size(arr.as_ref() as &dyn Array, size)? | ||
| } | ||
| ScalarValue::LargeListView(arr) => { | ||
| if size == 1 { | ||
| return Ok(Arc::clone(arr) as Arc<dyn Array>); | ||
| } | ||
| Self::list_to_array_of_size(arr.as_ref() as &dyn Array, size)? | ||
| } |
Contributor
There was a problem hiding this comment.
wondering if list arms can be combined into a single arm?
Contributor
Author
There was a problem hiding this comment.
I can't think of a way to do so, since arr in each case is &Arc<ListViewArray> and &Arc<LargeListViewArray> so we can't bind to a common name as they are distinct types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ListView,LargeListViewinScalarValue#18886ListViewandLargeListViewinScalarValue#18884Rationale for this change
More support for listview types in the codebase
What changes are included in this PR?
Added
ListViewandLargeListViewtoScalarValuewith all accompanying changesSupport
ListViewandLargeListViewin proto, both for the arrow datatype & the newly introduced scalarvalue variants.Are these changes tested?
Yes, added tests
Are there any user-facing changes?
No