Open
Conversation
github-actions
bot
added
logical-expr
joroKr21
force-pushed
the
opt/pushdown-filter
branch
2 times, most recently
from
8db87e3 to
7aee0a0
Compare
- Add a hidden `Filter::new` constructor that skips type-checking - Less allocations, more modification of mutable plan nodes - Less cloning, use references when possible
joroKr21
force-pushed
the
opt/pushdown-filter
branch
from
7aee0a0 to
6ce2a70
Compare
Contributor
|
@joroKr21 If the direction is agreed by the reviewer you should combine the pr, I will be happy to help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
try_uncheckedmore so I would adopt thatRationale for this change
What changes are included in this PR?
Filter::new_uncheckedconstructor that skips type-checkingAre these changes tested?
Relying on existing tests mostly, added a few more tests.
Are there any user-facing changes?
make_filteris removed, probably wasn't meant to be a public function.