Add strategy-focused InList benchmarks#21648
Merged
adriangb merged 2 commits intoapache:mainfrom Apr 16, 2026
Merged
Conversation
adriangb
approved these changes
Apr 15, 2026
Contributor
adriangb
left a comment
There was a problem hiding this comment.
The comments refer to optimizations which don't exist. Can we maybe reword this to be more general or refer to these as "cases" and things like "short strings, large list", "large strings, short list", etc.
CI failures are unrelated.
cffffd5 to
78c9d26
Compare
Contributor
Author
Good remark, I've reworked the comments and naming to avoid refering to the still hypothetical optims in a new commit. |
Add a new in_list_strategy benchmark file with targeted coverage of each optimization strategy, without replacing the existing in_list benchmarks which are kept intact for historical comparison. (cherry picked from commit d6e645d)
78c9d26 to
fa93228
Compare
Contributor
|
Thanks! I've rebased and plan to merge this once CI passes |
Contributor
|
Thanks @geoffreyclaude ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
IN LISToptimization series in IN LIST optims #19390.Rationale for this change
IN LISThas become the target of several specialized execution strategies, but the existing benchmark coverage indatafusion/physical-expr/benches/in_list.rsis mostly end-to-end and historical in nature. That broad coverage is useful for regression tracking, but it is not ideal for answering more focused questions such as:This PR adds a dedicated strategy benchmark harness for
IN LISTso future performance work can be evaluated against a stable, repeatable, strategy-focused corpus.This PR does not change
InListexecution behavior. It only adds benchmark coverage.What changes are included in this PR?
datafusion/physical-expr/benches/in_list_strategy.rsdatafusion/physical-expr/Cargo.tomlbenches/in_list.rsbenchmark suite intact for broader historical comparisonIN LISTstrategy families, including:NOT INscenariosIN LISTimplementationAre these changes tested?
Yes. I validated this PR with:
cargo fmt --allcargo clippy -p datafusion-physical-expr --all-targets --all-features -- -D warningscargo test -p datafusion-physical-expr in_list --libAre there any user-facing changes?
No user-facing changes. This PR only adds benchmark coverage for development and performance evaluation.