feat: Add Spark-compatible monthname function to datafusion-spark#21639
Open
JeelRajodiya wants to merge 3 commits intoapache:mainfrom
Open
feat: Add Spark-compatible monthname function to datafusion-spark#21639JeelRajodiya wants to merge 3 commits intoapache:mainfrom
monthname function to datafusion-spark#21639JeelRajodiya wants to merge 3 commits intoapache:mainfrom
Conversation
Implements `monthname(date_or_timestamp)` that returns the three-letter abbreviated month name (Jan, Feb, ..., Dec) from a date or timestamp, matching Apache Spark's behavior.
JeelRajodiya
force-pushed
the
feat/spark-monthname-function
branch
from
d13c56b to
a4228b9
Compare
Jefffrey
reviewed
Apr 16, 2026
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { |
Contributor
There was a problem hiding this comment.
Could we have these tests as SLTs instead?
Author
There was a problem hiding this comment.
Done! I've moved to SLTs. thanks for pointing it out.
Comment on lines
+110
to
+111
| Some(m) => Ok(month_number_to_name(m)), | ||
| None => Ok(None), |
Contributor
There was a problem hiding this comment.
Do these need to be Results?
Author
There was a problem hiding this comment.
I realized that date part would always return valit month int, so we don't need results. I've refoctored it.
| name.to_string(), | ||
| )))), | ||
| None => { | ||
| exec_err!("Invalid month number: {month_val}") |
Contributor
There was a problem hiding this comment.
This branch doesn't seem to be present on the array path below?
Author
There was a problem hiding this comment.
Thanks. I've made it consistant now.
JeelRajodiya
force-pushed
the
feat/spark-monthname-function
branch
from
d32a486 to
e066989
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The
datafusion-sparkcrate is missing themonthnamefunction. Spark'smonthname(date)returns the three-letter abbreviated month name (Jan, Feb, ..., Dec) from a date or timestamp — commonly used in Spark SQL workloads.What changes are included in this PR?
Adds
SparkMonthNametodatafusion-spark's datetime functions. It usesarrow::compute::date_part(DatePart::Month)to extract the month number and maps it to the abbreviated name. The signature accepts Timestamp types with automatic coercion from Date32/Date64.Are these changes tested?
Yes — 6 unit tests covering scalar dates, array dates with nulls, null scalars, timestamp microseconds, all 12 months, and return field nullability.
Are there any user-facing changes?
New
monthnamescalar function available when usingdatafusion-spark.