-
Notifications
You must be signed in to change notification settings - Fork 2k
Add ExpressionAnalyzer for pluggable expression-level statistics estimation #21122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
asolimando
wants to merge
15
commits into
apache:main
Choose a base branch
from
asolimando:asolimando/ndv-expression-analyzer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
cdfe641
Add ExpressionAnalyzer for pluggable expression-level statistics
asolimando d2cfed5
Fix CI: update config docs, sqllogictest, and doc links
asolimando 607c12d
Fix doc placement, import path, extract helper, defer selectivity com…
asolimando 016f405
Snapshot column stats for analyzer to avoid ordering dependency
asolimando 0a06358
Use registry NDV for equality/inequality selectivity on expressions
asolimando 3187d4a
Narrow injective arithmetic to addition and subtraction only
asolimando 8c2bbad
Make resolve_ndv symmetric: use max NDV across both operands
asolimando 54b7ff5
Clarify enable_expression_analyzer scope in config and doc comments
asolimando 8ea30fd
Inject ExpressionAnalyzerRegistry into exec nodes and re-inject via o…
asolimando 6fd0ae0
test(filter): verify ExpressionAnalyzer inclusion-exclusion selectivi…
asolimando 8aa003b
refactor(expression_analyzer): delegate when no NDV statistics are av…
asolimando 189287f
test(expression_analyzer): add StatisticsTable and end-to-end SLT for…
asolimando f39badd
fix: replace as_any().downcast_ref with downcast_ref after upstream a…
asolimando dfd77f3
fix: inject ExpressionAnalyzer registry before optimizer loop to clos…
asolimando b79d090
fix: align JoinStatisticsProvider with config gate, fall back to dire…
asolimando File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at the registry injection behavior and I agree the situation is better than it first appeared. Since
inject_expression_analyzerwalks the whole tree viatransform_upwhenever any optimizer rule changes the plan, nodes created earlier do end up getting the registry in most cases.That said, there is still a narrow gap. If every physical optimizer rule is a no-op, the injection pass never runs, and planner-built nodes remain without a registry. This is probably rare in practice, but it does mean the behavior still depends slightly on whether any rule fires.
It would be good to either close this gap entirely or document that this edge case exists so the behavior is easier to reason about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed as 1. in #21122 (comment)