chore: add confirmation before tarball is released#1372
chore: add confirmation before tarball is released#1372milenkovicm wants to merge 1 commit intoapache:mainfrom
Conversation
| read -r -p "Proceed to release tarball for ${version}-rc${rc}? [y/N]: " answer | ||
| answer=${answer:-no} | ||
| if [ "${answer}" != "y" ]; then | ||
| echo "Cancelled tarball release!" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Can we move it further down in the script? That way it would get through all of the steps and ask to confirm just before committing. Also if we do that maybe change the text to something along the lines of "Generated release tarball at XXX. Proceed to commit to SVN?"
There was a problem hiding this comment.
It would make sense if the script was creating a tarball and performing some complex logic. However, it’s simply copying the existing tarball from dev to release without any tarball manipulation.
I've pushed this update across all other DataFusion repositories. It would make sense to me if we keep tarball-release.sh the same across projects.
If you’re keen on change I’m happy to adapt but I’m feeling a bit stressed about testing it after this morning. 😀
2 participants
Which issue does this PR close?
Closes #.
Rationale for this change
Add confirmation dialogue to confirm tarball release
What changes are included in this PR?
Update
tarball-release.shto asky/Nconfirmation before it proceeds to release uploadAre there any user-facing changes?