[VMware] OVF Full properties support by nvazquez · Pull Request #4250 · apache/cloudstack

nvazquez · 2020-08-06T18:30:24Z

Description

Primate UI changes: apache/cloudstack-primate#550

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

nvazquez · 2020-08-06T20:10:20Z

@blueorangutan package

blueorangutan · 2020-08-06T20:10:57Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-08-06T20:42:30Z

Packaging result: ✔centos7 ✔debian. JID-1669

nvazquez · 2020-08-06T21:02:24Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2020-08-06T21:03:02Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

nvazquez · 2020-08-07T01:25:17Z

@blueorangutan test

blueorangutan · 2020-08-07T01:25:58Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr · 2020-08-07T07:37:58Z

@nvazquez still many failures in travis/simulator hinting at general regressions

yadvr · 2020-08-07T09:08:05Z

@nvazquez I triaged the issues for simulator/Travis, they are limited to test_vm_life_cycle and test_reset_vm_on_reboot failures now.

For the test_vm_life_cycle the following tests fail:

=== TestName: test_01_unmanage_vm_cycle | Status : EXCEPTION ===

Error log: (we probably should skip test/setup if hypervisor is not vmware?)

ERROR: test suite for <class 'integration.smoke.test_vm_life_cycle.TestVAppsVM'>   
----------------------------------------------------------------------                                                                                                  
Traceback (most recent call last):                                                  
  File "/usr/local/lib/python2.7/dist-packages/nose/suite.py", line 209, in run     
    self.setUp()                                                                    
  File "/usr/local/lib/python2.7/dist-packages/nose/suite.py", line 292, in setUp  
    self.setupContext(ancestor)                                                     
  File "/usr/local/lib/python2.7/dist-packages/nose/suite.py", line 315, in setupContext
    try_run(context, names)                                                         
  File "/usr/local/lib/python2.7/dist-packages/nose/util.py", line 471, in try_run 
    return func()                                                                   
  File "/home/rohit/lab/apache/cloudstack/test/integration/smoke/test_vm_life_cycle.py", line 1696, in setUpClass
    assert False, "get_test_ovf_templates() failed to return templates"             
AssertionError: get_test_ovf_templates() failed to return templates

...

2020-08-07 14:28:20,461 - DEBUG - ========Sending GET Cmd : createEgressFirewallRule=======
2020-08-07 14:28:20,484 - ERROR - Exception:['Traceback (most recent call last):\n', '  File "/usr/local/lib/python2.7/dist-packages/marvin/cloudstackConnection.py", line 308, in __parseAndGetResponse\n    response_cls)\n', '  File "/usr/local/lib/python2.7/dist-packages/marvin/jsonHelper.py", line 156, in getResultObj\n    raise cloudstackException.CloudstackAPIException(respname, errMsg)\n', 'CloudstackAPIException: Execute cmd: createegressfirewallrule failed, due to: errorCode: 537, errorText:There is already a firewall rule specified with protocol = all and no ports\n']

For test_reset_vm_on_reboot failure, I checked against master looks like this is failing on master as well due to:

java.lang.NullPointerException
	at com.cloud.vm.VirtualMachineManagerImpl.logBootModeParameters(VirtualMachineManagerImpl.java:1339)

I'll send a separate PR for this issue.

yadvr · 2020-08-07T09:10:11Z

@blueorangutan package

blueorangutan · 2020-08-07T09:10:57Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-08-07T09:53:59Z

Packaging result: ✔centos7 ✔debian. JID-1674

yadvr · 2020-08-07T10:00:22Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2020-08-07T10:01:13Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

yadvr · 2020-08-07T10:02:40Z

@nvazquez I've fixed issue #2 7707d3f which was due to a fwd-merge I did yesterday

blueorangutan · 2020-08-07T14:21:10Z

Trillian test result (tid-2290)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44595 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4250-t2290-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 81 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_reset_vm_on_reboot	`Error`	6.19	test_reset_vm_on_reboot.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Error`	420.63	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	`Failure`	148.04	test_vpc_redundant.py

blueorangutan · 2020-08-08T00:21:06Z

Trillian test result (tid-2298)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49508 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4250-t2298-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 79 look OK, 4 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_3d_gpu_support	`Error`	302.48	test_deploy_vgpu_enabled_vm.py
test_01_reset_vm_on_reboot	`Error`	5.20	test_reset_vm_on_reboot.py
test_11_migrate_vm	`Error`	50.96	test_vm_life_cycle.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Failure`	487.90	test_vpc_redundant.py

nvazquez · 2020-08-08T05:02:06Z

@blueorangutan package

blueorangutan · 2020-08-08T05:02:57Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-08-08T05:38:43Z

Packaging result: ✔centos7 ✔debian. JID-1678

yadvr · 2020-09-01T08:27:39Z

@blueorangutan package

blueorangutan · 2020-09-01T08:28:07Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-09-01T09:44:53Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1862

yadvr · 2020-09-01T10:24:21Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2020-09-01T10:25:12Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

nvazquez · 2020-09-01T15:04:17Z

@blueorangutan package

blueorangutan · 2020-09-01T15:05:13Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-09-01T15:43:11Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1880

nvazquez · 2020-09-02T11:41:21Z

@blueorangutan package

yadvr · 2020-09-03T20:30:56Z

@blueorangutan package

blueorangutan · 2020-09-04T05:00:32Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

yadvr · 2020-09-05T14:30:15Z

@blueorangutan package

blueorangutan · 2020-09-05T14:31:32Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-09-05T15:27:59Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1896

yadvr · 2020-09-05T15:53:51Z

@blueorangutan test matrix

blueorangutan · 2020-09-05T15:54:21Z

@rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2020-09-06T07:39:57Z

Trillian test result (tid-2668)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 53601 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4250-t2668-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 80 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Failure`	597.71	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	`Error`	3844.22	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	`Error`	3844.25	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	0.02	test_vpc_redundant.py
ContextSuite context=TestVPCRedundancy>:teardown	`Error`	0.03	test_vpc_redundant.py

nvazquez · 2020-09-07T17:07:03Z

@blueorangutan package

yadvr · 2020-09-07T18:01:57Z

@blueorangutan package

blueorangutan · 2020-09-07T18:02:32Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Support for vApp VM deployment for VMware Backend PR - apache/cloudstack#4250 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> Co-authored-by: nvazquez <nicovazquez90@gmail.com>

Support for vApp VM deployment for VMware Backend PR - #4250 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> Co-authored-by: nvazquez <nicovazquez90@gmail.com> Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

nvazquez added component:vmware component:templates labels Aug 6, 2020

nvazquez added this to the 4.15.0.0 milestone Aug 6, 2020

nvazquez mentioned this pull request Aug 6, 2020

[VMware] Full OVF properties support #4235

Closed

5 tasks

apache deleted a comment from blueorangutan Aug 6, 2020

nvazquez added the status:work-in-progress label Aug 6, 2020

yadvr added the Severity:Critical Critical bug label Aug 7, 2020

yadvr closed this Aug 7, 2020

yadvr reopened this Aug 7, 2020

nvazquez force-pushed the ovfprops-full branch from 01726b2 to 27e71aa Compare September 7, 2020 13:14

[VMware] Full OVF properties support

62dab4a

nvazquez force-pushed the ovfprops-full branch from 27e71aa to 62dab4a Compare September 7, 2020 17:06

nvazquez mentioned this pull request Sep 7, 2020

[VMware] vSphere advanced capabilities and Full OVF properties support #4307

Merged

5 tasks

nvazquez closed this Sep 7, 2020

apache deleted a comment from blueorangutan Sep 15, 2020

sureshanaparti mentioned this pull request Jun 30, 2021

db: Cleanup obsolete tables #5002

Merged

5 tasks

Conversation

nvazquez commented Aug 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

nvazquez commented Aug 6, 2020

Uh oh!

blueorangutan commented Aug 6, 2020

Uh oh!

blueorangutan commented Aug 6, 2020

Uh oh!

nvazquez commented Aug 6, 2020

Uh oh!

blueorangutan commented Aug 6, 2020

Uh oh!

nvazquez commented Aug 7, 2020

Uh oh!

blueorangutan commented Aug 7, 2020

Uh oh!

yadvr commented Aug 7, 2020

Uh oh!

yadvr commented Aug 7, 2020

Uh oh!

yadvr commented Aug 7, 2020

Uh oh!

blueorangutan commented Aug 7, 2020

Uh oh!

blueorangutan commented Aug 7, 2020

Uh oh!

yadvr commented Aug 7, 2020

Uh oh!

blueorangutan commented Aug 7, 2020

Uh oh!

yadvr commented Aug 7, 2020

Uh oh!

blueorangutan commented Aug 7, 2020

Uh oh!

blueorangutan commented Aug 8, 2020

Uh oh!

nvazquez commented Aug 8, 2020

Uh oh!

blueorangutan commented Aug 8, 2020

Uh oh!

blueorangutan commented Aug 8, 2020

Uh oh!

yadvr commented Sep 1, 2020

Uh oh!

blueorangutan commented Sep 1, 2020

Uh oh!

blueorangutan commented Sep 1, 2020

Uh oh!

yadvr commented Sep 1, 2020

Uh oh!

blueorangutan commented Sep 1, 2020

Uh oh!

nvazquez commented Sep 1, 2020

Uh oh!

blueorangutan commented Sep 1, 2020

Uh oh!

blueorangutan commented Sep 1, 2020

Uh oh!

nvazquez commented Sep 2, 2020

Uh oh!

yadvr commented Sep 3, 2020

Uh oh!

blueorangutan commented Sep 4, 2020

Uh oh!

yadvr commented Sep 5, 2020

Uh oh!

blueorangutan commented Sep 5, 2020

Uh oh!

blueorangutan commented Sep 5, 2020

Uh oh!

yadvr commented Sep 5, 2020

Uh oh!

blueorangutan commented Sep 5, 2020

Uh oh!

nvazquez commented Aug 6, 2020 •

edited

Loading