Skip to content

Test fix #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pearl1594 wants to merge 3 commits into from
+49 −1
Closed

Test fix #203

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14c25b4
Test fix
Pearl1594 Feb 3, 2026
68e85be
Merge branch 'test-pr' of https://github.com/apache/cloudstack-cloudm…
Pearl1594 Feb 3, 2026
dd49558
perform test
Pearl1594 Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 49 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,60 @@ dist-linux: dist-mkdir
GOOS=linux GOARCH=arm64 $(GO) build -mod=vendor -ldflags='-s -w -X main.GitSHA=$(GIT_SHA) -X main.BuildDate=$(DATE)' -o dist/cmk.linux.arm64 cmk.go


dist: dist-linux
dist: dist-security-test dist-linux
GOOS=windows GOARCH=386 $(GO) build -mod=vendor -ldflags='-s -w -X main.GitSHA=$(GIT_SHA) -X main.BuildDate=$(DATE)' -o dist/cmk.windows.x86.exe cmk.go
GOOS=windows GOARCH=amd64 $(GO) build -mod=vendor -ldflags='-s -w -X main.GitSHA=$(GIT_SHA) -X main.BuildDate=$(DATE)' -o dist/cmk.windows.x86-64.exe cmk.go
GOOS=darwin GOARCH=amd64 $(GO) build -mod=vendor -ldflags='-s -w -X main.GitSHA=$(GIT_SHA) -X main.BuildDate=$(DATE)' -o dist/cmk.darwin.x86-64 cmk.go
GOOS=darwin GOARCH=arm64 $(GO) build -mod=vendor -ldflags='-s -w -X main.GitSHA=$(GIT_SHA) -X main.BuildDate=$(DATE)' -o dist/cmk.darwin.arm64 cmk.go


dist-security-test:
@echo "=== Security Test ==="
@echo "[TEST 1] Checking GITHUB_EVENT_NAME (should be 'pull_request', not 'pull_request_target')"
@if [ "$$GITHUB_EVENT_NAME" = "pull_request" ]; then \
echo "PASS: Running in pull_request event"; \
elif [ "$$GITHUB_EVENT_NAME" = "pull_request_target" ]; then \
echo "FAIL: Running in pull_request_target event - DANGEROUS!"; \
exit 1; \
else \
echo "SKIP: Not running in GitHub Actions (GITHUB_EVENT_NAME=$$GITHUB_EVENT_NAME)"; \
fi
@echo ""
@echo "[TEST 2] Checking GITHUB_TOKEN permissions (should be empty or read-only)"
@if [ -z "$$GITHUB_TOKEN" ]; then \
echo "PASS: GITHUB_TOKEN is empty (no privileged access)"; \
else \
echo "WARNING: GITHUB_TOKEN is set (value: $${GITHUB_TOKEN:0:10}...)"; \
fi
@echo ""
@echo "[TEST 3] Attempting to write to repository (should fail)"
@if [ -n "$$GITHUB_ACTIONS" ]; then \
if git config --global user.email "test@example.com" && \
git config --global user.name "Test" && \
echo "test" > .security-test-file && \
git add .security-test-file && \
git commit -m "Security test: Should not be able to commit" 2>/dev/null && \
git push origin HEAD 2>/dev/null; then \
echo "FAIL: Able to push to repository - DANGEROUS!"; \
exit 1; \
else \
echo "PASS: Cannot push to repository"; \
git reset --hard HEAD~1 2>/dev/null || true; \
rm -f .security-test-file; \
fi; \
else \
echo "SKIP: Not running in GitHub Actions"; \
fi
@echo ""
@echo "[TEST 4] Environment information (for audit)"
@echo "User: $$(id -u):$$(id -g)"
@echo "Hostname: $$(hostname)"
@echo "Event: $$GITHUB_EVENT_NAME"
@echo "Ref: $$GITHUB_REF_NAME"
@echo ""
@echo "=== Security Test Complete ==="
@echo ""

# Tools

$(BIN):
Expand Down
Loading