service: fix 'occured' -> 'occurred' in DiskErrorsHandlerService messages#4742
Open
SAY-5 wants to merge 1 commit intoapache:trunkfrom
Open
service: fix 'occured' -> 'occurred' in DiskErrorsHandlerService messages#4742SAY-5 wants to merge 1 commit intoapache:trunkfrom
SAY-5 wants to merge 1 commit intoapache:trunkfrom
Conversation
…exception messages Two messages in src/java/org/apache/cassandra/service/DiskErrorsHandlerService.java (lines 57, 62) read 'Exception occured while'. Fixed to 'occurred'. String-literal-only change. Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
Contributor
|
Thanks for the contribution, but the level of testing in our ecosystem is much higher than most. While this seems like a very simple change, it may actually break a test somewhere. Would you be willing to do a more general set of spell checks across all messages and validate that the changes don't break anything? Since this is touching a java file, we will require a dtest run to validate it didn't create regressions. You can learn more about that here: https://cassandra.apache.org/_/development/testing.html |
pmcfadin
added
needs-committer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two messages in
src/java/org/apache/cassandra/service/DiskErrorsHandlerService.java(lines 57, 62) readException occured while. Fixed tooccurred. One is a logger.warn string, the other a ConfigurationException message. String-literal-only change.