CASSANALYTICS-150 Change commit log mode for CDC tests#197
CASSANALYTICS-150 Change commit log mode for CDC tests#197skoppu22 wants to merge 2 commits intoapache:trunkfrom
Conversation
arjunashok
left a comment
There was a problem hiding this comment.
The git-commit message seems to suggest this is only for tests. I’m wondering if it is only for tests, can we not switch/override it in the test implementation?
Do we intend to switch the default commit log mode?
Also, seems like Cassandra’s default is DiskAccessMode.legacy.
https://github.com/apache/cassandra/blob/addec0ef7ab4c9c023ae8f60c6af565c520368ff/src/java/org/apache/cassandra/config/Config.java#L430
|
+1. waiting for CI results |
The code is for testing only. It is to generate the commit logs to test CDC function. |
CDC tests setup in Cassandra analytics is using commit log disk access mode DIRECT. This is causing CI builds running on containers to fail with OOM, as unable to acquire sufficient DIRECT memory on memory constrained containers. Changing commit log mode to mmap works, and this aligns with Cassandra default commit log mode logic (see resolveCommitLogWriteDiskAccessMode in Cassandra)