Skip to content

CASSANALYTICS-150 Change commit log mode for CDC tests#197

Open
skoppu22 wants to merge 2 commits intoapache:trunkfrom
skoppu22:clmode
Open

CASSANALYTICS-150 Change commit log mode for CDC tests#197
skoppu22 wants to merge 2 commits intoapache:trunkfrom
skoppu22:clmode

Conversation

@skoppu22
Copy link
Copy Markdown
Contributor

@skoppu22 skoppu22 commented Apr 16, 2026

CDC tests setup in Cassandra analytics is using commit log disk access mode DIRECT. This is causing CI builds running on containers to fail with OOM, as unable to acquire sufficient DIRECT memory on memory constrained containers. Changing commit log mode to mmap works, and this aligns with Cassandra default commit log mode logic (see resolveCommitLogWriteDiskAccessMode in Cassandra)

@skoppu22 skoppu22 marked this pull request as draft April 16, 2026 12:21
@skoppu22 skoppu22 marked this pull request as ready for review April 16, 2026 14:50
@skoppu22
Copy link
Copy Markdown
Contributor Author

Copy link
Copy Markdown
Contributor

@arjunashok arjunashok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The git-commit message seems to suggest this is only for tests. I’m wondering if it is only for tests, can we not switch/override it in the test implementation?

Do we intend to switch the default commit log mode?

Also, seems like Cassandra’s default is DiskAccessMode.legacy.
https://github.com/apache/cassandra/blob/addec0ef7ab4c9c023ae8f60c6af565c520368ff/src/java/org/apache/cassandra/config/Config.java#L430

@yifan-c
Copy link
Copy Markdown
Contributor

yifan-c commented Apr 16, 2026

+1. waiting for CI results

@yifan-c
Copy link
Copy Markdown
Contributor

yifan-c commented Apr 16, 2026

The git-commit message seems to suggest this is only for tests. I’m wondering if it is only for tests, can we not switch/override it in the test implementation?

Do we intend to switch the default commit log mode?

Also, seems like Cassandra’s default is DiskAccessMode.legacy. https://github.com/apache/cassandra/blob/addec0ef7ab4c9c023ae8f60c6af565c520368ff/src/java/org/apache/cassandra/config/Config.java#L430

The code is for testing only. It is to generate the commit logs to test CDC function.

Copy link
Copy Markdown
Contributor

@frankgh frankgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants