CASSANALYTICS-146: Remove shutdownhooks in testing to prevent race on transaction log deletion#192
Open
jmckenzie-dev wants to merge 1 commit intoapache:trunkfrom
Open
CASSANALYTICS-146: Remove shutdownhooks in testing to prevent race on transaction log deletion#192jmckenzie-dev wants to merge 1 commit intoapache:trunkfrom
jmckenzie-dev wants to merge 1 commit intoapache:trunkfrom
Conversation
Contributor
jyothsnakonisa
left a comment
jyothsnakonisa
left a comment
There was a problem hiding this comment.
Looks good just few minor comments. Not sure if you need to add this to changes.txt
Contributor
Author
Good question. I forgot about CHANGES.txt, but now that we're talking about it - I think test only changes probably are best left out since they're not user facing. wdyt? |
Contributor
|
Makes sense, we can omit changes.txt changes. BTW CI is failing, can you please look into fixing them? |
jyothsnakonisa
approved these changes
Apr 10, 2026
jmckenzie-dev
force-pushed
the
fix_shutdown_hook
branch
from
1e34325 to
9c6504e
Compare
Contributor
Author
|
Rebased, squashed, and re-running CI. If it's clean (ish; i.e. no new failures that aren't being addressed by 143 or 145), I'll merge. |
jmckenzie-dev
changed the title
… transaction log deletion Patch by Josh McKenzie; reviewed by Jyothsna Konisa for CASSANALYTICS-146 - Fix shared state and cluster reset failures in BulkReaderMultiDCConsistencyTest - Reset resources in shared cluster test hierarchy - Change DiskAccessMode in CdcBridgeImplementation.java to mmap
jmckenzie-dev
force-pushed
the
fix_shutdown_hook
branch
from
9c6504e to
339ac2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch by Josh McKenzie; reviewed by Jyothsna Konisa for CASSANALYTICS-146