Create singleton view for pipeline options during pipeline construction.

[claudevdm]

Create pipeline_construction_options singleton (PipelineConstructionOptions) to hold PipelineOptions during graph construction

Add PipelineOptions.is_compat_version_prior_to() method and migrate all callers from the standalone is_compat_version_prior_to() / is_v1_prior_to_v2() functions in util.py

Move force_dill_deterministic_coders test flag from typecoders.registry to the singleton

Remove unused --force_cloudpickle_deterministic_coders pipeline option

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @claudevdm, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors how pipeline options are accessed and managed during the construction of an Apache Beam pipeline. By introducing a singleton for PipelineOptions and centralizing compatibility version checks within the PipelineOptions class itself, the changes aim to improve code organization, reduce redundancy, and enhance the clarity of how pipeline configurations are applied and evaluated. This leads to a more robust and maintainable system for handling pipeline-wide settings.

Highlights

• Centralized Pipeline Options Management: A new singleton, PipelineConstructionOptions, has been introduced to centrally hold PipelineOptions during the pipeline graph construction phase. This ensures consistent access to pipeline configuration throughout the build process.
• Refactored Compatibility Version Checks: The PipelineOptions class now includes a dedicated method, is_compat_version_prior_to(), for checking compatibility versions. This method replaces previous standalone utility functions (is_v1_prior_to_v2 and is_compat_version_prior_to in util.py), streamlining version comparison logic.
• Relocation of Test Flag: The force_dill_deterministic_coders test flag has been moved from typecoders.registry to the new pipeline_construction_options singleton, consolidating test-related configuration.
• Removal of Unused Pipeline Option: The --force_cloudpickle_deterministic_coders pipeline option, which was no longer in use, has been removed to simplify the codebase and options parsing.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[claudevdm]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a well-designed refactoring by creating a pipeline_construction_options singleton to manage pipeline options during graph construction. This centralizes access and simplifies the codebase. The migration of the compatibility version check to PipelineOptions.is_compat_version_prior_to() with comprehensive new tests is a great improvement. The removal of the unused --force_cloudpickle_deterministic_coders option and moving the force_dill_deterministic_coders flag are also good cleanups.

I have one critical comment regarding a test that appears to be broken by this refactoring due to a latent issue.

[codecov]

Codecov Report

❌ Patch coverage is 68.42105% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.97%. Comparing base (b61995d) to head (5a04053).
⚠️ Report is 38 commits behind head on master.

Files with missing lines	Patch %	Lines
...ks/python/apache_beam/coders/coders_test_common.py	33.33%	4 Missing ⚠️
...dks/python/apache_beam/options/pipeline_options.py	57.14%	3 Missing ⚠️
sdks/python/apache_beam/transforms/util.py	50.00%	2 Missing ⚠️
...s/python/apache_beam/io/gcp/bigquery_file_loads.py	0.00%	1 Missing ⚠️
sdks/python/apache_beam/transforms/external.py	0.00%	1 Missing ⚠️
sdks/python/apache_beam/transforms/ptransform.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             master   #37474       +/-   ##
=============================================
- Coverage     54.94%   35.97%   -18.98%     
  Complexity     1676     1676               
=============================================
  Files          1065     1063        -2     
  Lines        166089   165903      -186     
  Branches       1208     1208               
=============================================
- Hits          91265    59687    -31578     
- Misses        72643   104035    +31392     
  Partials       2181     2181               

Flag	Coverage Δ
python	39.93% <68.42%> (-40.77%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[claudevdm]

R: @shunping

[github-actions]

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

[claudevdm]

assign set of reviewers

[github-actions]

Assigning reviewers:

R: @shunping for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[claudevdm]

R: @tvalentyn

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

[claudevdm]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a singleton to hold pipeline options during graph construction, which is a good step towards centralizing configuration. However, the current implementation of the singleton is not thread-safe, which could lead to race conditions if multiple pipelines are constructed concurrently. I've provided a critical comment with a suggestion to use threading.local to address this. The rest of the refactoring, including moving the compatibility version check to PipelineOptions and cleaning up related code, is well-executed and improves the codebase.