[AURON #2011] History Server fails when BuildInfo event is missing.#2012
Open
slfan1989 wants to merge 1 commit intoapache:masterfrom
Open
[AURON #2011] History Server fails when BuildInfo event is missing.#2012slfan1989 wants to merge 1 commit intoapache:masterfrom
slfan1989 wants to merge 1 commit intoapache:masterfrom
Conversation
…ing. Signed-off-by: slfan1989 <slfan1989@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2011
Rationale for this change
The History Server plugin currently crashes during initialization when the
AuronBuildInfoUIDatarecord is missing from the KVStore. This causes applications without BuildInfo events to either fail plugin initialization or show no Auron tab.What changes are included in this PR?
buildInfo()to returnOption[AuronBuildInfoUIData], catchingNoSuchElementExceptionand other exceptions to returnNoneinstead of throwingbuildInfoSummary()method to handleOption[AuronBuildInfoUIData]:Some: displays BuildInfo table as beforeNone: shows user-friendly message "Auron build information is not available for this application."Are there any user-facing changes?
Yes. When BuildInfo is not available:
How was this patch tested?