feat(ipc): add with_skip_validation to StreamDecoder #9749
Open
pantShrey wants to merge 1 commit intoapache:mainfrom
Open
feat(ipc): add with_skip_validation to StreamDecoder #9749pantShrey wants to merge 1 commit intoapache:mainfrom
pantShrey wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A - this is a small API parity fix.
Rationale for this change
StreamReaderandFileDecoderboth exposewith_skip_validationbutStreamDecoderdoes not, despite having the same internalskip_validationfield.Motivation: DataFusion's spill infrastructure is being refactored to use
StreamDecoderfor reading spill files via a pluggable backend trait (apache/datafusion#21215). Since DataFusion controls what it writes it can trust its own IPC output, and needs this method to maintain the same performance characteristic as the current StreamReader-based implementationWhat changes are included in this PR?
Adds
with_skip_validationtoStreamDecodermirroring the existing implementation onFileDecoderAre these changes tested?
The existing StreamDecoder tests cover the decoding path. No new tests added as this method sets an internal flag already tested via
FileDecoderandStreamReader.Are there any user-facing changes?
Yes,
with_skip_validationis now available onStreamDecoder. It is marked unsafe with the same safety requirements asFileDecoder::with_skip_validation.