Draft
Conversation
alamb
force-pushed
the
alamb/primitive-array-mut-or-clone
branch
from
27a36b4 to
f288169
Compare
alamb
changed the title
PrimitiveArray mut-or-clone helpers
Contributor
Author
|
I would like to to try and use these downstream in datafusion before marking this PR ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
PrimitiveArray::unary_mut,PrimitiveArray:try_unary_mut, etc #8808Rationale for this change
Inspired by @mbutrovich in
I want to add some helper methods to the PrimitiveArray to make it easier to modify in place when possible, and clone when not possible.
What changes are included in this PR?
Add the equivalent APIs primitive_array:
PrimitiveArray::unary_mut_or_clonePrimitiveArray::try_unary_mut_or_clonePrimitiveArray::binary_mut_or_clonePrimitiveArray::try_binary_mut_or_cloneAlong with doc examples and pointer-reuse tests. It also factors
arrow::compute::binarythrough the sharedPrimitiveArraybinary implementation.Are these changes tested?
Yes by CI
Are there any user-facing changes?
Yes. New APIs