Skip to content

GH-130: Fix AutoCloseables to work with @Nullable structures #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
axreldable wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GH-130: Fix AutoCloseables to work with @Nullable structures #1017

axreldable wants to merge 1 commit into from
+311 −18

Conversation

@axreldable
Copy link
Contributor

@axreldable axreldable commented Feb 12, 2026 •
edited
Loading

What's Changed

AutoCloseables supposes to work with nullable Iterables, varargs, and collection of nulls. The PR introduces:

  • @Nullable annotation for all public methods in AutoCloseables (only private flatten method doesn't support null Iterable)
  • null checks to prevent NPEs

The change is backward compatible. Only possible NPEs are prevented.

Closes #130 .

@github-actions

This comment has been minimized.

Sign in to view
@axreldable
Copy link
Contributor Author

axreldable commented Feb 12, 2026

Please add the enhancement label.

@lidavidm lidavidm added the enhancement PRs that add or improve features. label Feb 13, 2026
@github-actions github-actions bot added this to the 19.0.0 milestone Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidavidm lidavidm Awaiting requested review from lidavidm lidavidm is a code owner

@laurentgo laurentgo Awaiting requested review from laurentgo laurentgo is a code owner

@wgtmac wgtmac Awaiting requested review from wgtmac wgtmac is a code owner

@jbonofre jbonofre Awaiting requested review from jbonofre jbonofre is a code owner

Assignees

No one assigned

Labels

enhancement PRs that add or improve features.

Projects

None yet

Milestone

19.0.0

Development

Successfully merging this pull request may close these issues.

[Java] Checker Framework annotations for AutoCloseables in arrow-memory-core are incorrect

2 participants

@axreldable @lidavidm