Skip to content

Manage Tags: Handle review comments#20798

Merged
lukstbit merged 3 commits intoankidroid:mainfrom
david-allison:tags-viewmodel-fixup
Apr 21, 2026
Merged

Manage Tags: Handle review comments#20798
lukstbit merged 3 commits intoankidroid:mainfrom
david-allison:tags-viewmodel-fixup

Conversation

@david-allison
Copy link
Copy Markdown
Member

@david-allison david-allison commented Apr 20, 2026 •
edited
Loading

Fixes

Approach

See commits

How Has This Been Tested?

  • Dev-only, trusting CI

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison requested a review from lukstbit April 20, 2026 14:14
@david-allison david-allison force-pushed the tags-viewmodel-fixup branch 2 times, most recently from b8ac219 to 9f4f2cf Compare April 20, 2026 14:19
@david-allison
fix(manage-tags): Exception handling
b3dfe35 
* CancellationException
* Set state to an error on failure

Issue 10397
@david-allison
refactor(manage-tags): renames/moves
f71f684 
* TagListItem -> TagListItemState
* ManageTagsState.Loaded -> Content
* ManageTagsEvent => DisplayMessage (removed interface)
* launchTagOperation => launchTagOpAndRefresh

Issue 10397
@david-allison
fix(tags): validate TagName
4e22815 
* An empty tag is invalid
* Tags may not contain spaces

Issue 10397
lukstbit
lukstbit approved these changes Apr 21, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Review labels Apr 21, 2026
@lukstbit lukstbit added this pull request to the merge queue Apr 21, 2026
Merged via the queue into ankidroid:main with commit 3b0413f Apr 21, 2026
15 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Apr 21, 2026
@github-actions github-actions bot added this to the 2.24 release milestone Apr 21, 2026
@david-allison david-allison deleted the tags-viewmodel-fixup branch April 21, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukstbit lukstbit lukstbit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.24 release

Development

Successfully merging this pull request may close these issues.

2 participants

@david-allison @lukstbit