Fix FAB visibility after SearchView dismissal on deck deletion#20797
Merged
criticalAY merged 1 commit intoankidroid:mainfrom Apr 21, 2026
Merged
Fix FAB visibility after SearchView dismissal on deck deletion#20797criticalAY merged 1 commit intoankidroid:mainfrom
criticalAY merged 1 commit intoankidroid:mainfrom
Conversation
Fixes bug in DeckPicker: open toolbar SearchView -> FAB is hidden -> long click deck -> delete deck -> Info SnackBar appears, SearchView is closed, FAB is still missing Deleting the deck would refresh the menu so the SearchView gets rebuilt and its listeners(which handle the FAB) would not get triggered. The fix sets the the FAB as visible when the delete deck handler is hit, just before the SnackBar is requested.
david-allison
approved these changes
Apr 20, 2026
david-allison
added
Needs Second Approval
criticalAY
approved these changes
Apr 21, 2026
Contributor
criticalAY
left a comment
criticalAY
left a comment
There was a problem hiding this comment.
Missed this one, thanks!
criticalAY
added
Pending Merge
github-actions
bot
removed
the
Pending Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
A small fix for the following bug in DeckPicker:
Open toolbar SearchView -> FAB is hidden -> long click deck -> delete deck -> Info SnackBar appears, SearchView is closed, at this point FAB is still missing(and remains missing until search is used)
Note: similar issue with SearchView opened and trying to undo something, fab goes missing. This is more difficult(we undo, show a snackbar while the undo also triggers an opExecuted call and a menu refresh again) to fix and also less likely to happen vs the deck deletion situation above.
How Has This Been Tested?
Ran tests, checked the bug behavior.
Checklist