[Multiple-Profile]fix: external directory not created for profile

[criticalAY]

Purpose / Description

Fixes a VERY BIG BLUNDER that I did earlier, I overlooked external dir. but thanks to @david-allison I figured this one, apart from deletion the addition logic was also missing

Fixes

• Fixes part of Add support for profiles #18117

Approach

See commit

How Has This Been Tested?

Unit test to verify that directory was created

Learning (optional, can help others)

Always doc first

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[david-allison]

This seems incorrect, I'm not sure I understand the logic

[david-allison]

This is unusual, we typically use PREF_COLLECTION_PATH ("deckPath")

[criticalAY]

Ahh I was doing the job indirectly in a pretty fragile ( the actual collection location isnt read from getExternalFilesDir() which I assumed. i.e. PREF_COLLECTION_PATH <- Read from here)

[david-allison]

Look into getDefaultAnkiDroidDirectory

[david-allison]

Given the complexity here, let's simplify it further

[david-allison]

I understand the complexity, but I feel it should be moved inside getDefaultAnkiDroidDirectory

ideally some of the complexity can be fixed inside the method call

        val ankiDroidDir = getDefaultAnkiDroidDirectory(appContext, directoryName = profileId.value).apply {
            mkdirs()
        }