Skip to content

AmdSmiPlugin update: cper AFID val#122

Open
alexandraBara wants to merge 2 commits intodevelopmentfrom
alex_amdsmi_cper
Open

AmdSmiPlugin update: cper AFID val#122
alexandraBara wants to merge 2 commits intodevelopmentfrom
alex_amdsmi_cper

Conversation

@alexandraBara
Copy link
Collaborator

How to test:

(venv) alexbara@smci350-odcdh1-a06-2:~/node-scraper$ node-scraper run-plugins AmdSmiPlugin --collection True --analysis False --cper-file-path /home/alexbara/cpers/corrected-3.cper
  2026-02-04 16:18:41 CST       INFO               nodescraper | Log path: ./scraper_logs_smci350_odcdh1_a06_2_2026_02_04-04_18_41_PM
  2026-02-04 16:18:41 CST       INFO               nodescraper | System Name: smci350-odcdh1-a06-2
  2026-02-04 16:18:41 CST       INFO               nodescraper | System SKU: None
  2026-02-04 16:18:41 CST       INFO               nodescraper | System Platform: None
  2026-02-04 16:18:41 CST       INFO               nodescraper | System location: SystemLocation.LOCAL
  2026-02-04 16:18:41 CST       INFO               nodescraper | Initializing connection manager for InBandConnectionManager with default args
  2026-02-04 16:18:41 CST       INFO               nodescraper | --------------------------------------------------
  2026-02-04 16:18:41 CST       INFO               nodescraper | Running plugin AmdSmiPlugin
  2026-02-04 16:18:41 CST       INFO               nodescraper | Initializing connection: InBandConnectionManager
  2026-02-04 16:18:41 CST       INFO               nodescraper | Using local shell
  2026-02-04 16:18:41 CST       INFO               nodescraper | Checking OS family
  2026-02-04 16:18:41 CST       INFO               nodescraper | OS Family: LINUX
  2026-02-04 16:18:41 CST       INFO               nodescraper | Running data collector: AmdSmiCollector
  2026-02-04 16:18:41 CST       INFO               nodescraper | amd-smi version: 26.0.0
  2026-02-04 16:18:41 CST       INFO               nodescraper | ROCm version: 7.0.1
  2026-02-04 16:18:42 CST       INFO               nodescraper | Successfully retrieved AFID from CPER file: /home/alexbara/cpers/corrected-3.cper
  2026-02-04 16:18:42 CST       INFO               nodescraper | (AmdSmiPlugin) task completed successfully
  2026-02-04 16:18:42 CST       INFO               nodescraper | Closing connections
  2026-02-04 16:18:42 CST       INFO               nodescraper | Running result collators
  2026-02-04 16:18:42 CST       INFO               nodescraper | Running TableSummary result collator
  2026-02-04 16:18:42 CST       INFO               nodescraper |

+-------------------------+--------+-----------------------------+
| Connection              | Status | Message                     |
+-------------------------+--------+-----------------------------+
| InBandConnectionManager | OK     | task completed successfully |
+-------------------------+--------+-----------------------------+

+--------------+--------+-------------------------------------+
| Plugin       | Status | Message                             |
+--------------+--------+-------------------------------------+
| AmdSmiPlugin | OK     | Plugin tasks completed successfully |
+--------------+--------+-------------------------------------+

  2026-02-04 16:18:42 CST       INFO               nodescraper | Data written to csv file: ./scraper_logs_smci350_odcdh1_a06_2_2026_02_04-04_18_41_PM/nodescraper.csv

or

node-scraper --plugin-configs plugin_config.json

where plugin_config.json:

{
  "global_args": {},
  "plugins": {
    "AmdSmiPlugin": {
      "collection_args": {
        "cper_file_path": "/path/to/cpers/corrected-3.cper"
      }
    }
  },
  "result_collators": {}
}

Copy link
Collaborator

@graepaul graepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments.

I think there would be benefit to have AFID be automatically generated on collected CPERs

xgmi_metric: Optional[list[XgmiMetrics]] = Field(default_factory=list)
xgmi_link: Optional[list[XgmiLinks]] = Field(default_factory=list)
cper_data: Optional[list[FileModel]] = Field(default_factory=list)
cper_afid: Optional[int] = None
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a list like cper_data


# If cper_file_path is provided, get AFID from the CPER file
if args and args.cper_file_path:
afid = self._get_cper_afid(args.cper_file_path)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have this also be performed on recently collected cpers automatically, in addition to having this option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants