Skip to content

Feat/0.0.4 housekeeping#39

Merged
lcarcaramo merged 9 commits into
devfrom
feat/0.0.4-housekeeping
Jun 11, 2026
Merged

Feat/0.0.4 housekeeping#39
lcarcaramo merged 9 commits into
devfrom
feat/0.0.4-housekeeping

Conversation

@lcarcaramo

@lcarcaramo lcarcaramo commented Jun 11, 2026

Copy link
Copy Markdown
Member

💡 Issue Reference

Issue: N/A

💻 What does this address?

  • Update clang-format.yml GitHub Action to use clang-format-20.
  • Update CMakeLists.txt to have a standard "install" target rather than a custom "package" target.
  • Update Jenkinsfile to do CLI/C/C++ install test using the "install" target.
  • Update Jenkinsfile to create the CLI/C/C++ pax by creating a pax from an installation created using the "install" target.
  • Update Jenkinsfile to use cmake commands rather than gmake commands to invoke CMake/Make targets.
  • Make updates to refer to the "Shell" distribution as the "CLI" distribution.
  • README cleanup.
  • Update parameter naming in cbxp.cpp.
  • Add ASCII art for the general usage output for the CBXP CLI.
  • Use poll() instead of isatty() to check if data was provided via a pipe.
    • The problem is that the isatty() test depended on the terminal being a TTY. If the terminal is not a TTY, the test does not work. The poll() method works regardless of whether the terminal is a TTY or not.
  • Remove offset= option from the CBXP Python binding. It is easy enough to take slice of a Python bytes object, so the offset= option does not really add much for the CBXP Python binding unlike the CBXP CLI.
  • Cleanup tests and test data.
  • Ensure required feature test macros are provided for isatty() and fileno()
  • Fix SHA256SUMS.txt.asc generation in Jenkinsfile.
    • The problem is that sha256sum -t was being used, which runs sha256sum in text mode and caused the checksums to get generated incorrectly. Interestingly, it seems like this used to work correctly, but now it doesn't. This issue likely manifested as a result of change to the build agent environment.

📋 Is there a test case?

All functional tests are passing.

Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
…)/fileno()

Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
@lcarcaramo lcarcaramo added this to the v0.0.4 milestone Jun 11, 2026

@ElijahSwiftIBM ElijahSwiftIBM left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the code changes look good to me and it still passes all tests and some minor function testing. Looks ready for release to me.

Signed-off-by: Leonard Carcaramo <lcarcaramo@ibm.com>
@lcarcaramo lcarcaramo merged commit f3104f2 into dev Jun 11, 2026
11 checks passed
@lcarcaramo lcarcaramo deleted the feat/0.0.4-housekeeping branch June 11, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants