Skip to content

chore: use published core package in examples #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alongubkin merged 1 commit into from
Jun 11, 2026
Merged

chore: use published core package in examples #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions examples/byoc-database/bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/byoc-database/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"test": "vitest run"
},
"devDependencies": {
"@alienplatform/core": "link:../../packages/core",
"@alienplatform/core": "^1.7.0",
"@alienplatform/testing": "^0.1.0",
"@types/node": "^22.10.5",
"typescript": "^5.7.3",
Expand Down
9 changes: 5 additions & 4 deletions examples/endpoint-agent/bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/endpoint-agent/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"test:watch": "vitest"
},
"devDependencies": {
"@alienplatform/core": "link:../../packages/core",
"@alienplatform/core": "^1.7.0",
"@alienplatform/testing": "^0.1.0",
"@types/node": "^22.10.5",
"typescript": "~5.7.2",
Expand Down
2 changes: 1 addition & 1 deletion examples/full-stack-microservices/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"test:ts": "pnpm --filter './services/*' test:ts"
},
"devDependencies": {
"@alienplatform/core": "link:../../packages/core",
"@alienplatform/core": "^1.7.0",
"typescript": "^5.7.3"
}
Comment on lines 10 to 13

@greptile-apps greptile-apps Bot Jun 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Missing pnpm lockfile for reproducible installs

The three bun-based examples each have an updated bun.lock committed alongside their package.json changes, so bun install --frozen-lockfile works cleanly. full-stack-microservices uses pnpm but has no committed pnpm-lock.yaml. After this change a user cloning the example and running pnpm install will get whatever versions resolve at that point in time rather than a pinned, reproducible set — which is at odds with the stated goal of downloaded examples installing cleanly. Running pnpm install in this directory and committing the resulting pnpm-lock.yaml would close the gap.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: examples/full-stack-microservices/package.json
Line: 10-13

Comment:
**Missing pnpm lockfile for reproducible installs**

The three bun-based examples each have an updated `bun.lock` committed alongside their `package.json` changes, so `bun install --frozen-lockfile` works cleanly. `full-stack-microservices` uses pnpm but has no committed `pnpm-lock.yaml`. After this change a user cloning the example and running `pnpm install` will get whatever versions resolve at that point in time rather than a pinned, reproducible set — which is at odds with the stated goal of downloaded examples installing cleanly. Running `pnpm install` in this directory and committing the resulting `pnpm-lock.yaml` would close the gap.

How can I resolve this? If you propose a fix, please make it concise.

}
9 changes: 7 additions & 2 deletions examples/github-agent/packages/remote-agent/bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/github-agent/packages/remote-agent/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
},
"dependencies": {
"@alienplatform/sdk": "^1.0.0",
"@alienplatform/core": "link:../../../../packages/core",
"@alienplatform/core": "^1.7.0",
"hono": "^4.0.0",
"zod": "^3.24.1"
},
Expand Down
Loading