Merged
Conversation
Collaborator
Author
|
did some benchmarks on all the vector indexes we support (hnsw, ivf, flat, hnsw-rabitq), the performance seemed alright. ready to merge |
zhourrr
force-pushed
the
feat/enlarge_topk
branch
from
2075129 to
ce8490b
Compare
feihongxu0824
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enlarged topK limit to 100K. Hopefully this resolves #335 and the majority of use cases. I'm doing some benchmarking to verify the correctness. TopK has never ever been this large before...