feat: add 3-pass adversarial review protocol to CEO prompt#515
Open
RobotSail wants to merge 3 commits into
Open
feat: add 3-pass adversarial review protocol to CEO prompt#515RobotSail wants to merge 3 commits into
RobotSail wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #515 +/- ##
=======================================
Coverage 86.77% 86.77%
=======================================
Files 64 64
Lines 10027 10027
=======================================
Hits 8701 8701
Misses 1326 1326 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Upgrade the --mode review pipeline from a single-reviewer, single-pass approach to a 3-reviewer, 3-round adversarial protocol with cross-pollination. Changes: - factory/agents/prompts/ceo.md: Add Mode: PR Review section with full 3-pass protocol (PR1-PR6 steps, language detection, cross-pollination, adversarial stress test, consolidated verdict) - factory/cli.py: Update --mode review task string to reference the new protocol instead of the old single-reviewer instructions - skills/3-pass-review/SKILL.md: Add standalone skill for manual invocation via /3-pass-review <PR#> The protocol runs 3 independent reviewers (code quality, language-specific, security) across 3 rounds. Each round, reviewers see the others' prior findings — forcing them to challenge, validate, and go deeper. Round 3 is explicitly adversarial (try to break the PR). The CEO consolidates all findings into a structured KEEP/REVERT verdict.
RobotSail
force-pushed
the
feature/3-pass-review
branch
from
fb5c013 to
7f923ae
Compare
Collaborator
|
@akashgit can you take a look at this one. it will change the review logic significantly. |
Each reviewer sees its own full prior trajectory in subsequent rounds but only receives concise summaries from the other reviewers. This preserves depth without anchoring or context bloat. CEO writes summaries after each round as a mandatory step.
osilkin98
added
extends-functionality
enhancement
Collaborator
|
@ceo-review |
Collaborator
|
@ceo-review you did not actually look, can you please review? |
Contributor
Author
|
@ceo-review can you check this out? |
osilkin98
added
kind:hardening
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1
Changes
## Mode: PR Review (--mode review --pr <N>)section to the CEO agent prompt