feat: rename --mode interactive to --mode design + Symphony-style SPEC.md output#494
Closed
akashgit wants to merge 2 commits into
Closed
feat: rename --mode interactive to --mode design + Symphony-style SPEC.md output#494akashgit wants to merge 2 commits into
akashgit wants to merge 2 commits into
Conversation
…C.md output Two tightly coupled changes: 1. Mode rename (interactive → design): Renamed ~125 mode-concept references across 6 files (cli.py, ceo.md, distiller.md, CLAUDE.md, test_cli.py, test_cli_wizard.py). Variables renamed (interactive_idea → design_idea, interactive_existing → design_existing). Step labels renamed I0-I4 → D0-D4 in CEO prompt. --mode interactive accepted as silent backward-compat alias. Runner-concept references (interactive_run, supports_interactive) untouched. 2. SPEC.md output format: Replaced ad-hoc idea.md template in distiller.md with Symphony-style numbered sections (Problem Statement, Goals/Non-Goals, System Overview, Core Domain Model, Detailed Specifications, Reference Algorithms, Test and Validation Matrix, Implementation Checklist) and RFC 2119 normative language. Updated CEO prompt D1/D1r to embed format requirements and review criteria for Symphony-style structure. Closes #490 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The Builder incorrectly renamed "running in interactive mode" to "running in foreground mode" in the CEO prompt — those lines refer to non-headless execution, not the CLI --mode flag being renamed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
@ceo-review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Factory Review: REVERT
Verdict: REVERT
Reason: Test failure: tests/test_prompts.py::TestDistillerPrompt::test_has_output_format expects old template format (## Vision, ## Core Features, ## Architecture) but Distiller now outputs Symphony format with numbered sections. Fix required before merge.
Posted by Factory CEO
osilkin98
added
competing
Collaborator
|
closed in favor of #498 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--mode interactiveto--mode designacross CLI, CEO prompt, Distiller prompt, CLAUDE.md, and tests--mode interactiveis kept as a silent backward-compatible aliasCloses #440
Files changed (6)
factory/cli.py— mode rename, wizard labels, variable names, backward compat aliasfactory/agents/prompts/ceo.md— Phase 0 section: Interactive → Design, I0-I4 → D0-D4factory/agents/prompts/distiller.md— SPEC.md format template with Symphony structureCLAUDE.md— documentation references updatedtests/test_cli.py— test class/method renames + alias teststests/test_cli_wizard.py— wizard command string updatesTest plan
tests/test_cli.py+tests/test_cli_wizard.py)--mode interactiveaccepted as alias for--mode designtest_ceo_mode_interactive_alias,test_interactive_alias_works🤖 Generated with Claude Code