Skip to content

Rename --mode interactive to --mode design + adopt Symphony-style SPEC.md output#492

Closed
akashgit wants to merge 1 commit into
mainfrom
factory/run-56886a82
Closed

Rename --mode interactive to --mode design + adopt Symphony-style SPEC.md output#492
akashgit wants to merge 1 commit into
mainfrom
factory/run-56886a82

Conversation

@akashgit

@akashgit akashgit commented Jun 5, 2026

Copy link
Copy Markdown
Owner

Closes #490

Changes

  • Mode rename (interactive → design): Renamed ~125 mode-concept references across 6 files. Variables interactive_ideadesign_idea, interactive_existingdesign_existing. Step labels I0-I4D0-D4 in CEO prompt. --mode interactive accepted as silent backward-compat alias. Runner-concept references (interactive_run, supports_interactive) are untouched.
  • SPEC.md output format: Replaced ad-hoc idea.md template in distiller.md with Symphony-style numbered sections (Problem Statement, Goals/Non-Goals, System Overview, Core Domain Model, Detailed Specifications, Reference Algorithms, Test and Validation Matrix, Implementation Checklist) using RFC 2119 normative language. Updated CEO prompt D1/D1r to embed format requirements and review criteria.
  • Tests updated: All test classes and methods renamed, backward-compat alias test added. 303 tests passing.
  • Lint/type clean: ruff check . and mypy factory/ pass with zero issues.

…C.md output

Two tightly coupled changes:

1. Mode rename (interactive → design): Renamed ~125 mode-concept references
   across 6 files (cli.py, ceo.md, distiller.md, CLAUDE.md, test_cli.py,
   test_cli_wizard.py). Variables renamed (interactive_idea → design_idea,
   interactive_existing → design_existing). Step labels renamed I0-I4 → D0-D4
   in CEO prompt. --mode interactive accepted as silent backward-compat alias.
   Runner-concept references (interactive_run, supports_interactive) untouched.

2. SPEC.md output format: Replaced ad-hoc idea.md template in distiller.md
   with Symphony-style numbered sections (Problem Statement, Goals/Non-Goals,
   System Overview, Core Domain Model, Detailed Specifications, Reference
   Algorithms, Test and Validation Matrix, Implementation Checklist) and
   RFC 2119 normative language. Updated CEO prompt D1/D1r to embed format
   requirements and review criteria for Symphony-style structure.

Closes #490

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@akashgit

akashgit commented Jun 5, 2026

Copy link
Copy Markdown
Owner Author

❌ Factory Review: REVERT

Verdict: REVERT
Reason: Guard violation: working tree has dirty eval/score.py (overwritten by factory discover). No eval scores recorded — cannot verify threshold or regression.

Experiment: #1
Hypothesis: Rename interactive mode to design mode and adopt Symphony-style SPEC.md output

Score Comparison

Metric Value
Before 0.0000
After 0.0000
Delta +0.0000
Threshold 0.6000

Guard Checks

Check Result
eval_immutable ❌ FAIL
git_clean ❌ FAIL
experiment_branch ✅ PASS
scope ✅ PASS

Precheck Gate

score_direction:FAIL (0.0 < 0.6 threshold), anti_pattern:PASS, smoke_test:PASS

Code Review Notes

  • Code quality is CLEAN — CEO review found no issues
  • All renames (interactive→design) are consistent across 6 files (~125 locations)
  • Backward compat alias correctly implemented (if mode == interactive: mode = design)
  • New tests cover alias behavior (test_ceo_mode_interactive_alias, test_interactive_alias_works)
  • SPEC.md Symphony-style format template properly structured in distiller.md
  • REVERT reason is procedural (dirty worktree + missing evals), not code quality

Posted by Factory CEO

@xukai92 xukai92 marked this pull request as ready for review June 9, 2026 20:59
@osilkin98 osilkin98 added competing Another open PR solves the same problem kind:capability Does something new stage:intent Capturing/protecting what the user wants (specs, scope, design) labels Jun 11, 2026
@xukai92

xukai92 commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

closed in favor of #498

@xukai92 xukai92 closed this Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

competing Another open PR solves the same problem kind:capability Does something new stage:intent Capturing/protecting what the user wants (specs, scope, design)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename --mode interactive to --mode design + adopt Symphony-style SPEC.md output

3 participants