fix: pass max_retries and timeout_sec from YAML config to LLMClient#232
Open
dennis-lynch-nv wants to merge 1 commit intoaiming-lab:mainfrom
Open
fix: pass max_retries and timeout_sec from YAML config to LLMClient#232dennis-lynch-nv wants to merge 1 commit intoaiming-lab:mainfrom
dennis-lynch-nv wants to merge 1 commit intoaiming-lab:mainfrom
Conversation
LlmConfig dataclass and _parse_llm_config() did not read max_retries or timeout_sec from the YAML config. LLMClient.from_rc_config() also did not forward these values to LLMConfig. This caused the LLMClient to always use the hardcoded default of 3 retries regardless of the user's config.arc.yaml setting. Fixes: - Add max_retries and timeout_sec fields to LlmConfig dataclass - Parse both values in _parse_llm_config() from YAML - Forward both values in LLMClient.from_rc_config() to LLMConfig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LlmConfigdataclass and_parse_llm_config()inconfig.pydid not readmax_retriesortimeout_secfrom the YAML config file. Additionally,LLMClient.from_rc_config()inclient.pydid not forward these values toLLMConfig.This caused the
LLMClientto always use the hardcoded default of 3 retries and 300s timeout regardless of what the user set inconfig.arc.yaml.For example, setting
max_retries: 8in config had no effect — the client still retried only 3 times.Fix
config.py— Addedmax_retriesandtimeout_secfields to theLlmConfigdataclass, and parse them in_parse_llm_config()client.py—LLMClient.from_rc_config()now forwards both values toLLMConfigVerification