Make source code pip-installable and command line interface#1
Open
hdsassnick wants to merge 2 commits intoaimat-lab:mainfrom
Open
Make source code pip-installable and command line interface#1hdsassnick wants to merge 2 commits intoaimat-lab:mainfrom
hdsassnick wants to merge 2 commits intoaimat-lab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following enhancements/fixes:
pyproject.tomlfile such that the package can be distributed via pypi and installed via pip.dynamic_oracle_listis now deprecated.TO-DOs:
Update README.Add dependencies topyproject.toml.@zzc558: it would be great if you could double-check that the functionality is maintained. You should be able to pull this branch and run
pip install .in the source directory (with thepyproject.tomlfile). And thenmpirun pal_engine -sf al_setting.pyin the 'project' directory. Everything else should work the same way as before. Your feedback is highly appreciated. If you agree with the changes, I would finish the TO-DOs and the PR can be merged.Edit: All to-dos are done. This PR would be ready to be merged.