feat(scan): support data-options config on auto.global.js script tag#442
Draft
Debbl wants to merge 1 commit into
Draft
feat(scan): support data-options config on auto.global.js script tag#442Debbl wants to merge 1 commit into
Debbl wants to merge 1 commit into
Conversation
Read configuration from a `data-options` JSON attribute on the loading
<script> tag so CDN users can configure react-scan declaratively without
an extra init script. Mirrors react-grab's `getScriptOptions` pattern:
parse synchronously at module top-level so `document.currentScript`
still resolves, guard with `instanceof HTMLScriptElement`, and wrap
JSON.parse in try/catch.
Use an explicit allowlist with per-field type validation rather than
spreading parsed JSON, so internal flags like `_debug` or
`dangerouslyForceRunInProduction` cannot be injected through HTML.
Currently allowlists only `enabled`. The JSON shape is preserved over a
`data-enabled` shortcut so future fields can be added with one
allowlist line as their localStorage interaction is vetted.
Usage:
<script src=".../auto.global.js" data-options='{"enabled":false}'></script>
Existing localStorage merge in setOptions still wins for `enabled`, so
user toolbar toggles persist over the script-tag default — same
semantics as calling `scan({ enabled: false })` from JS.
Refresh the website's bundled copy at packages/website/public/auto.global.js
to match.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
@Debbl is attempting to deploy a commit to the Million Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
data-optionsJSON attribute onauto.global.jsso CDN users can configure react-scan declaratively, no separate init script needed:Same pattern as react-grab's getScriptOptions — read at module top-level via document.currentScript, JSON-parsed in a try/catch.