feat: support modelTypes whitelist for discovered LM Studio models#26
Open
scott1028 wants to merge 1 commit into
Open
feat: support modelTypes whitelist for discovered LM Studio models#26scott1028 wants to merge 1 commit into
scott1028 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for filtering auto-discovered LM Studio models via
provider.lmstudio.options.modelTypes.Previously, the plugin always added every discovered model that was not already configured. With this change, users can optionally whitelist discovered models by type.
Supported values:
chatembeddingunknownThe legacy
options.model_typeskey is also preserved for backward compatibility.Changes
modelTypes/model_typesparsing in config enhancementprovider.lmstudio.modelsembedded->embeddingmodelTypesoption in the READMEmodelTypesis not configuredchatunknownmodelTypesvaluesembeddedmodel_typesBehavior Notes
modelTypesis currently inferred from the LM Studio modelid, not from a dedicated type field returned by the API.unknownmeans the discovered model ID does not match the plugin's currentchatorembeddingcategorization rules.Testing
npm run test:run22/22)