feat(tool): preserve Event block types in SubAgentTool forwardEvent#1282
Open
jujn wants to merge 2 commits intoagentscope-ai:mainfrom
Open
feat(tool): preserve Event block types in SubAgentTool forwardEvent#1282jujn wants to merge 2 commits intoagentscope-ai:mainfrom
jujn wants to merge 2 commits intoagentscope-ai:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates SubAgentTool.forwardEvent to forward sub-agent streaming events without losing the original ContentBlock subtypes (e.g., ToolUseBlock), addressing the type-erasure problem described in #980. It also adds a fallback behavior to emit an empty block when an event has no content.
Changes:
- Updated
SubAgentTool.forwardEventto emit the originalMsgcontent blocks (instead of JSON text) and attach event metadata (subagent_event_type,subagent_event_last, etc.). - Added an empty
TextBlockfallback when an event has no content blocks to forward. - Updated
SubAgentToolTestto assert preservedContentBlocktypes and correct metadata population.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| agentscope-core/src/main/java/io/agentscope/core/tool/subagent/SubAgentTool.java | Emit original event content blocks and attach event metadata; add empty-block fallback. |
| agentscope-core/src/test/java/io/agentscope/core/tool/subagent/SubAgentToolTest.java | Update streaming-forwarding test to validate block-type preservation and metadata. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Close #980
Enhance SubAgentTool forwardEvent to preserve original ContentBlock types and provide empty block fallback.
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)