fix(skill): support custom charset for zip extraction#1276
Open
fang-tech wants to merge 2 commits intoagentscope-ai:mainfrom
Open
fix(skill): support custom charset for zip extraction#1276fang-tech wants to merge 2 commits intoagentscope-ai:mainfrom
fang-tech wants to merge 2 commits intoagentscope-ai:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for non-UTF-8 zip skill packages by allowing callers to specify the Charset used when decoding zip entry names and extracted text content.
Changes:
- Added
Charsetoverloads forSkillUtil.createFromZip(...)across byte arrays, paths, and input streams. - Updated zip extraction to use the provided charset for entry-name decoding and text decoding.
- Added a unit test that validates extraction using a GBK-encoded zip.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| agentscope-core/src/main/java/io/agentscope/core/skill/util/SkillUtil.java | Adds charset-aware createFromZip overloads and uses charset for ZipInputStream + content decoding. |
| agentscope-core/src/test/java/io/agentscope/core/skill/SkillUtilTest.java | Adds a GBK-based zip extraction test and charset-aware zip test helper. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
1.0.11
Description
Charsetoverloads toSkillUtil.createFromZip(...)for byte arrays, paths, and input streamsmalformed inputduring entry decodingChecklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)