fix(openai): ensure assistant messages always have a content field to prevent 400 errors#1273
Open
jujn wants to merge 4 commits intoagentscope-ai:mainfrom
Open
fix(openai): ensure assistant messages always have a content field to prevent 400 errors#1273jujn wants to merge 4 commits intoagentscope-ai:mainfrom
jujn wants to merge 4 commits intoagentscope-ai:mainfrom
Conversation
… prevent 400 errors
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes OpenAI-compatible API request failures (e.g., vLLM Qwen3 reasoning mode and DashScope compatible-mode) by ensuring assistant messages always include a content field, preventing 400 Bad Request errors when an assistant message contains only tool calls / reasoning blocks.
Changes:
- Ensure
OpenAIMessageConverter.convertAssistantMessage()setscontentto""when extracted text content is null/empty. - Add a regression test to validate
assistantmessages with tool-only content serialize with non-nullcontent.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| agentscope-core/src/main/java/io/agentscope/core/formatter/openai/OpenAIMessageConverter.java | Always sets assistant content (falls back to empty string) to satisfy strict OpenAI-compatible endpoints. |
| agentscope-core/src/test/java/io/agentscope/core/formatter/openai/OpenAIMessageConverterTest.java | Adds a regression test covering tool-only assistant messages to prevent content-missing requests. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Close #1268 #1270
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)