fix: sanitize null values in tool arguments to prevent empty field errors#1256
Open
Jim1874 wants to merge 1 commit intoagentscope-ai:mainfrom
Open
fix: sanitize null values in tool arguments to prevent empty field errors#1256Jim1874 wants to merge 1 commit intoagentscope-ai:mainfrom
Jim1874 wants to merge 1 commit intoagentscope-ai:mainfrom
Conversation
…rors When passing objects as tool parameters, empty/null fields cause errors in downstream APIs. This fix: - Adds toMapWithSanitizedNulls() in JacksonJsonCodec to recursively replace null values and empty nested maps with empty strings - Updates DashScopeToolsHelper.convertToolCalls() to use sanitization - Updates OpenAIMessageConverter to use same sanitization Fixes agentscope-ai#1163
|
huangzhimou seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix tool parameter conversion bug where passing an object with empty fields causes errors. Null values are now sanitized to empty strings or empty arrays before being passed to tool arguments.
Changes
DashScopeToolsHelper.javaandOpenAIMessageConverter.javaJacksonJsonCodec.javawith utility for safe null-to-empty conversion