Open
Conversation
*Onboard study space Resolves: [MWPW-186604](https://jira.corp.adobe.com/browse/MWPW-186604) **Test URLs:** - Before: hhttps://stage--da-dc--adobecom.aem.page/drafts/ruchika/study-space/quiz-maker?unitylibs=stage - After: https://stage--da-dc--adobecom.aem.page/drafts/ruchika/study-space/quiz-maker?unitylibs=dc-study-space Note: DC block is not on stage yet ([PR](adobecom/da-dc#26) open), till then unity flow can be tested here https://ims--da-dc--adobecom.aem.page/acrobat/online/test/unity/study-marquee?unitylibs=dc-study-space Study space on product side is also not on stage, so please test a.com side of features. Also please do a quick sanity for other workflows too as workflow.js has been updated. --------- Co-authored-by: Ruchika Sinha <tek10248@Ruchikas-MacBook-Pro-2.local> Co-authored-by: Ruchika Sinha <tek10248@Ruchikas-MacBook-Pro.local> Co-authored-by: Cursor <cursoragent@cursor.com>
…#678) * [Temporary] Updating our file type validation such that for the HEIC verb, we will perform a file extension check * This logic will be updated to be generalized for all verbs later with this ticket: [MWPW-182430](https://jira.corp.adobe.com/browse/MWPW-182430) Resolves: [MWPW-188830](https://jira.corp.adobe.com/browse/MWPW-188830) **Test URLs:** - Before: https://stage--dc-frictionless--adobecom.aem.page/heic-to-pdf?unitylibs=stage - After: https://stage--dc-frictionless--adobecom.aem.page/heic-to-pdf?unitylibs=MWPW-188830
…ite (#682) This PR includes below changes 1. Support in target config and other files for integrating new upload-marquee block 2. Added support for light dark theme in splash screen. The logic is basis the theme class passed in the unity block. 3. Additional Analytics support for sending unity analytics for the Edit photos CTA 4. Unity FE handoff logic for doodlebug Resolves: [MWPW-188359](https://jira.corp.adobe.com/browse/MWPW-188359) **Test URLs:** - Before: https://stage--cc--adobecom.aem.page/drafts/doodlebug/remove-object - After: https://stage--cc--adobecom.aem.page/drafts/doodlebug/remove-object?unitylibs=doodlebug Testing Notes: 1. Validate E2E workflow for project doodlebug 2. Validate added analytics and error scenarios 3. Validate the final redirect firefly URL 4. Validate dark splash screen for doodlebug 5. Validate already existing FF pages that they should not have any changes in behaviour/splashscreen 6. Validate existing upload workflows for other products like ps, lr and expect no change in them --------- Co-authored-by: Sanjay Saravanan <75960494+sanjayms01@users.noreply.github.com> Co-authored-by: vipulg <vipulg@adobe.com> Co-authored-by: Arushi Gupta <65466846+arugupta1992@users.noreply.github.com> Co-authored-by: Arushi Gupta <arugupta@arushis-mbp.corp.adobe.com> Co-authored-by: Arushi Gupta <arugupta@Arushis-MacBook-Pro.local>
…ound (#677) Testing Notes: Basic sanity required. Pick pdf-editor for the sanity and do it on US vpn to trigger the challenger workflow. Resolves: https://jira.corp.adobe.com/browse/MWPW-182868 https://jira.corp.adobe.com/browse/MWPW-188630 **Test URLs:** - Before: https://main--dc--adobecom.aem.live/acrobat/online/pdf-editor?unitylibs=stage - After: https://main--dc--adobecom.aem.live/acrobat/online/pdf-editor?unitylibs=mwpw182868 --------- Co-authored-by: Arushi Gupta <arugupta@Arushis-MacBook-Pro.local>
…en errors caused by IMS token fetch failures (#685) <!-- Before submitting, please review all open PRs. --> * Fix error message serialization for `pre_upload_error_fetching_access_token` error code * Previously, the LANA log was logging the error object as `[object Object]`, making it unreadable: `Error Code: pre_upload_error_fetching_access_token, Status: null, Message: Unable to process the request, Info: Upload Type: single; Could not fetch access token; Error: [object Object], Account Type: signed-in` * Wrapped `originalError` with `JSON.stringify` so the full error details are now captured in the log * Treat IMS `invalid_credentials` error as a guest user instead of a fatal error, allowing the flow to continue gracefully Resolves: [MWPW-186021](https://jira.corp.adobe.com/browse/MWPW-186021) **Test URLs:** - Before: https://stage--dc--adobecom.aem.live/drafts/nala/acrobat/online/test/compress-pdf/?martech=off - After: https://stage--dc--adobecom.aem.live/drafts/nala/acrobat/online/test/compress-pdf?unitylibs=MWPW-186021&martech=off
…nalytics (#684) **Test URLs:** - Before: https://doodlebug--cc--adobecom.aem.page/drafts/doodlebug/remove-object?unitylibs=stage - After: https://doodlebug--cc--adobecom.aem.page/drafts/doodlebug/remove-object?unitylibs=db-analytics Co-authored-by: Arushi Gupta <arugupta@Arushis-MacBook-Pro.local>
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[MWPW-186604] Onboard study space
MWPW-188830 Temp change to validate file extension for HEIC file type (
[MWPW-188359] Adding Unity FE support for firefly project Doodlebug Lite (
[MWPW-182868,MWPW-188630] Removing the logging when target data not found (
[MWPW-186021] fix(LANA): Resolve pre_upload_error_fetching_access_token errors caused by IMS token fetch failures (
Changes to send verb name and action in the workflow firefly-upload analytics (
Test URLs:
Before: https://main--cc--adobecom.aem.live/products/firefly?unitylibs=main
After: https://main--cc--adobecom.aem.live/products/firefly?unitylibs=stage
Before: https://stage--dc--adobecom.aem.page/acrobat/online/pdf-to-png?unitylibs=main
After: https://stage--dc--adobecom.aem.page/acrobat/online/pdf-to-png?unitylibs=stage