fix: allow Tabs selectedKey to be null #9585
Open
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeljohn
force-pushed
the
fix-tabs-null-selectedkey
branch
from
e7fc400 to
6eac44d
Compare
abeljohn
commented
Feb 3, 2026
| // Ensure a tab is always selected (in case no selected key was specified or if selected item was deleted from collection) | ||
| let selectedKey = currentSelectedKey; | ||
| if (props.selectedKey == null && (selectionManager.isEmpty || selectedKey == null || !collection.getItem(selectedKey))) { | ||
| if (props.selectedKey === undefined && (selectionManager.isEmpty || selectedKey == null || !collection.getItem(selectedKey))) { |
Contributor
Author
There was a problem hiding this comment.
my understanding is that we only want to do this in the uncontrolled case, seeing as we don't do this when props.selectedKey is a non-null Key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9584
✅ Pull Request Checklist:
📝 Test Instructions:
Set Tabs'
selectedKeyto null