Skip to content

feat: Add secondary reference line#824

Merged
c-lamoureux merged 6 commits into
mainfrom
AN-450459
Jun 18, 2026
Merged

feat: Add secondary reference line#824
c-lamoureux merged 6 commits into
mainfrom
AN-450459

Conversation

@tanugarg04

@tanugarg04 tanugarg04 commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Description

Adds secondary?: boolean to the S2 component (AN-450459). Secondary lines are a lighter-emphasis variant intended for contextual values (averages, baselines) that should visually recede behind a primary target line.

Visual differences vs. primary:

  • No caret caps (start and end triangles omitted)
  • Rule spans full chart width (no cap-clearance offsets on either side)
  • Stroke and label color is size-dependent: gray-600 at XS, gray-800 for S/M/L and auto mode

Stroke weight always 1px.

LineReferenceLine.story.tsx — adds SecondaryBasic, WithSecondary, and PrimaryAndSecondary stories

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Comment thread packages/docs/docs/spectrum2/line.md Outdated
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

@c-lamoureux c-lamoureux merged commit cb4ba7a into main Jun 18, 2026
6 checks passed
@c-lamoureux c-lamoureux deleted the AN-450459 branch June 18, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants