[AN-450465] S2 Line: Trendline showEndCaps prop for aggregate methods#804
Open
c-lamoureux wants to merge 1 commit into
Open
[AN-450465] S2 Line: Trendline showEndCaps prop for aggregate methods#804c-lamoureux wants to merge 1 commit into
c-lamoureux wants to merge 1 commit into
Conversation
Adds optional arrowhead caps at both endpoints of average/median trendlines. Reuses REFERENCE_LINE_START_CAP_PATH / REFERENCE_LINE_END_CAP_PATH path marks already defined in constants; not supported for regression or window methods. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
showEndCaps?: booleantoTrendlineOptions. Whentrue, renders caret end markers (reusingREFERENCE_LINE_START_CAP_PATH/REFERENCE_LINE_END_CAP_PATH) at both ends of aggregate trendlines (mean, median, mode, min, max). Scoped to aggregate methods only — regression and window trendlines do not support end caps.Related Issue
Jira: AN-450465 (AN-450439)
Motivation and Context
The S2 Figma designs show trendlines with optional caret decorations at both ends, matching the reference line visual language. This prop brings trendline end caps into parity with that design intent.
How Has This Been Tested?
Types of changes
Checklist:
🤖 Generated with Claude Code