[AN-450442] S2 Line: Direct label background rect stays opaque during highlight#803
Open
c-lamoureux wants to merge 1 commit into
Open
[AN-450442] S2 Line: Direct label background rect stays opaque during highlight#803c-lamoureux wants to merge 1 commit into
c-lamoureux wants to merge 1 commit into
Conversation
…t dimming Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
Fixes direct label background rect remaining opaque during hover/highlight dimming. Separates the opacity encoding so the background rect always uses
{ value: 1 }while the colored text mark uses the highlight opacity signal.Related Issue
Jira: AN-450442 (AN-450439)
Motivation and Context
When hovering a line series, non-hovered series dim. The direct label background rect was incorrectly inheriting the highlight opacity, causing it to fade with the text instead of staying opaque to maintain label legibility.
How Has This Been Tested?
lineDirectLabelUtils.test.ts)LineDirectLabel.story.tsx (DirectLabelOpaqueBackground)Screenshots (if appropriate):
Types of changes
Checklist:
🤖 Generated with Claude Code