Skip to content

[AN-450442] S2 Line: Direct label background rect stays opaque during highlight#803

Open
c-lamoureux wants to merge 1 commit into
mainfrom
epic/AN-450439/AN-450442
Open

[AN-450442] S2 Line: Direct label background rect stays opaque during highlight#803
c-lamoureux wants to merge 1 commit into
mainfrom
epic/AN-450439/AN-450442

Conversation

@c-lamoureux

Copy link
Copy Markdown
Contributor

Description

Fixes direct label background rect remaining opaque during hover/highlight dimming. Separates the opacity encoding so the background rect always uses { value: 1 } while the colored text mark uses the highlight opacity signal.

Related Issue

Jira: AN-450442 (AN-450439)

Motivation and Context

When hovering a line series, non-hovered series dim. The direct label background rect was incorrectly inheriting the highlight opacity, causing it to fade with the text instead of staying opaque to maintain label legibility.

How Has This Been Tested?

  • Unit tests updated and passing (lineDirectLabelUtils.test.ts)
  • Regression story added: LineDirectLabel.story.tsx (DirectLabelOpaqueBackground)
  • MetricRange and Trendline confirmed unaffected
  • Build and TSC verified clean

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

🤖 Generated with Claude Code

…t dimming

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@github-actions

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant