S2 vega-spec-builder Title offset and ai workflow tweaks#776
Open
c-lamoureux wants to merge 3 commits into
Open
S2 vega-spec-builder Title offset and ai workflow tweaks#776c-lamoureux wants to merge 3 commits into
c-lamoureux wants to merge 3 commits into
Conversation
- Storybook lifecycle moved to orchestrator: started once in Phase 0, kept alive across all verify iterations, torn down after final report. Port is derived from STORYBOOK_AI_PORT in .env; PID tracked so only the process we started gets killed. - Screenshot script now accepts --port flag and auto-attaches to an already-running server instead of starting its own instance. Also extracts the Vega svg.marks element as result.svg for structural diff. - New structural comparison step in verify-chart-story reads both reference.structure.json and result.structure.json before the visual pass, catching gridline count, tick count, font sizes, and per-tick data shape fidelity. - Analyze skill gains SVG path → data value derivation using gridline positions as a ruler, replacing qualitative dataShapeHypothesis. - Generate skill now requires decomposing compound design features before classifying feasibility (tick count vs values, title text vs font size). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
planning doc for an axis tick value prop feature that passes through to Vega and allows direct control over axis tick values. This is a proposed feature and is not being implemented yet.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
Building out S2 design features.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: