ci: bump Node to 24.x to fix release workflow#262
Merged
Conversation
Node 24 ships with npm 11.x which supports trusted publishing, so the self-upgrade step (which was failing with a `promise-retry` MODULE_NOT_FOUND during npm's own rebuild) is no longer needed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
pxrl
approved these changes
Apr 27, 2026
gsteenkamp89
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update npmstep inrelease.yml; Node 24 ships with npm 11.x, which already supports trusted publishingWhy
The release run on master is failing at
npm install -g npm@latest:This is an npm self-upgrade race: arborist's rebuild step re-requires
promise-retrywhile the new npm is overwriting those same files in the global prefix. Bumping Node to 24 removes the need to self-upgrade entirely, since the bundled npm already meets the trusted-publishing minimum (≥ 11.5.1).Failing run: https://github.com/across-protocol/toolkit/actions/runs/24985150975/job/73156684308
Test plan
Build Lint & Testworkflow passes on this PR (validates Node 24 for the regular CI path)Releaseworkflow on master gets past the previously-failing step🤖 Generated with Claude Code