Skip to content

ci: bump Node to 24.x to fix release workflow#262

Merged
dohaki merged 1 commit intomasterfrom
ci/bump-node-24
Apr 27, 2026
Merged

ci: bump Node to 24.x to fix release workflow#262
dohaki merged 1 commit intomasterfrom
ci/bump-node-24

Conversation

@dohaki
Copy link
Copy Markdown
Collaborator

@dohaki dohaki commented Apr 27, 2026

Summary

  • Bump both workflows from Node 22 → 24
  • Remove the Update npm step in release.yml; Node 24 ships with npm 11.x, which already supports trusted publishing

Why

The release run on master is failing at npm install -g npm@latest:

npm error code MODULE_NOT_FOUND
npm error Cannot find module 'promise-retry'
npm error - .../npm/node_modules/@npmcli/arborist/lib/arborist/rebuild.js

This is an npm self-upgrade race: arborist's rebuild step re-requires promise-retry while the new npm is overwriting those same files in the global prefix. Bumping Node to 24 removes the need to self-upgrade entirely, since the bundled npm already meets the trusted-publishing minimum (≥ 11.5.1).

Failing run: https://github.com/across-protocol/toolkit/actions/runs/24985150975/job/73156684308

Test plan

  • Build Lint & Test workflow passes on this PR (validates Node 24 for the regular CI path)
  • After merge, confirm the Release workflow on master gets past the previously-failing step

🤖 Generated with Claude Code

Node 24 ships with npm 11.x which supports trusted publishing, so the
self-upgrade step (which was failing with a `promise-retry` MODULE_NOT_FOUND
during npm's own rebuild) is no longer needed.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
toolkit-example Ready Ready Preview, Comment Apr 27, 2026 8:56am

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 27, 2026

⚠️ No Changeset found

Latest commit: afcb93d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dohaki dohaki merged commit d275c92 into master Apr 27, 2026
3 checks passed
@dohaki dohaki deleted the ci/bump-node-24 branch April 27, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants