fix: move zod to dependencies (fixes #260)#261
Merged
Conversation
The SDK imports zod at runtime in api/ modules, but it was only declared as a devDependency. Consumers without zod transitively in their tree failed at build with "Rollup failed to resolve import \"zod\"". Fixes #260. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dohaki
requested review from
amateima,
ashwinrava,
gsteenkamp89,
melisaguevara,
mrice32 and
nicholaspai
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: d0a6693 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gsteenkamp89
approved these changes
Apr 27, 2026
Collaborator
gsteenkamp89
left a comment
gsteenkamp89
left a comment
There was a problem hiding this comment.
Nice thanks @dohaki
pxrl
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zodfromdevDependenciestodependenciesinpackages/sdk/package.jsonso consumers' build tools can resolve it.zodat runtime fromsrc/api/{suggested-fees,swap-approval,available-routes,validators}.ts. Since 0.5.0 these imports surface in the publisheddist/, breaking consumers (e.g. Vite/Rollup) withoutzodtransitively in their tree.Fixes #260.
Test plan
pnpm installsucceeds and updates the lockfile.pnpm --filter @across-protocol/app-sdk buildsucceeds.zodin its tree builds against a locally packed tarball.🤖 Generated with Claude Code