Skip to content

[codex] refactor confd run startup orchestration#611

Draft
abtreece wants to merge 1 commit into
mainfrom
codex/split-run-startup-orchestration
Draft

[codex] refactor confd run startup orchestration#611
abtreece wants to merge 1 commit into
mainfrom
codex/split-run-startup-orchestration

Conversation

@abtreece
Copy link
Copy Markdown
Owner

@abtreece abtreece commented May 8, 2026

Summary

  • Split cmd/confd run startup flow into focused helpers for backend config, logging, SRV discovery, observability, template config, processor selection, and supervision.
  • Added unit coverage for the new helper boundaries and shutdown supervision.
  • Preserved validation-mode behavior so check/validate exits still avoid SRV/backend work.

Fixes #602

Testing

  • go test ./cmd/confd
  • go test ./pkg/service
  • go test ./...
  • go vet ./cmd/confd
  • git diff --check

Note: make lint / golangci-lint run ./... failed locally before analysis with: context loading failed: no go files to analyze.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

❌ Patch coverage is 31.25000% with 77 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.86%. Comparing base (9837764) to head (6d9f2c5).

Files with missing lines Patch % Lines
cmd/confd/cli.go 31.25% 73 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
+ Coverage   70.96%   71.86%   +0.90%     
==========================================
  Files          53       53              
  Lines        5682     5711      +29     
==========================================
+ Hits         4032     4104      +72     
+ Misses       1422     1375      -47     
- Partials      228      232       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: split cmd/confd run startup orchestration

1 participant