Add support for Bazel MODULE.bazel module manifests (fixes #4123)#4806
Add support for Bazel MODULE.bazel module manifests (fixes #4123)#4806kumarasantosh wants to merge 2 commits intoaboutcode-org:developfrom
Conversation
kumarasantosh
force-pushed
the
add-bazel-module-support
branch
from
dae779f to
5c27c08
Compare
…r to parse MODULE.bazel manifests - Parses module() for name and version - Parses bazel_dep() including dev_dependency flag - Adds test fixture and test cases Fixes aboutcode-org#4123 Signed-off-by: kumarasantosh <santosh.pulikond02@gmail.com>
kumarasantosh
force-pushed
the
add-bazel-module-support
branch
from
5c27c08 to
5257b7c
Compare
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
@kumarasantosh thanks, see comments and general comments from the review at #4803 (review), some major changes required.
| default_package_type = 'bazel' | ||
| description = 'Bazel BUILD' | ||
| documentation_url = 'https://bazel.build/' | ||
| datasource_id = "bazel_build" |
There was a problem hiding this comment.
Can you add examples of codebases where bazel build and module manifests are both present together and how the functionality handles both together, and merging through assembly?
There was a problem hiding this comment.
| ) | ||
| return get_mapping_and_expression_from_detections(license_detections=license_detections) | ||
|
|
||
|
|
There was a problem hiding this comment.
There are also MODULE.bazel.lock files we need to handle https://github.com/google/allocation-instrumenter/blob/master/MODULE.bazel.lock
Signed-off-by: kumarasantosh <santosh.pulikond02@gmail.com>
kumarasantosh
force-pushed
the
add-bazel-module-support
branch
from
53085a6 to
6cfd5e4
Compare
|
Thanks for the review, @AyanSinhaMahapatra . I’ve addressed the Bazel feedback—added MODULE.bazel.lock support, improved assembly to merge module files, included a real-world fixture, and added end-to-end tests to verify detection and merging. Please take another look when you have time. |
2 participants
Adds BazelModuleHandler to parse MODULE.bazel files (Bzlmod format).
Closes #4123