UN-3413 [MISC] Replace deprecated app-id input with client-id in release workflow#1917
Merged
jaseemjaskp merged 1 commit intomainfrom Apr 17, 2026
Merged
Conversation
Contributor
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughUpdated GitHub App authentication in the release workflow by replacing the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
| Filename | Overview |
|---|---|
| .github/workflows/create-release.yaml | Single-line change: replaces deprecated app-id input with client-id and updates the referenced repo variable — correct and non-breaking once the new variable is populated. |
Sequence Diagram
sequenceDiagram
participant W as Workflow Runner
participant A as create-github-app-token@v3
participant G as GitHub API
W->>A: client-id from PUSH_TO_MAIN_APP_CLIENT_ID var
A->>G: Request installation access token
G-->>A: App Installation Token
A-->>W: outputs.token
W->>G: gh release create using outputs.token
Reviews (1): Last reviewed commit: "UN-3413 [MISC] Replace deprecated app-id..." | Re-trigger Greptile
Contributor
Test ResultsSummary
Runner Tests - Full Report
SDK1 Tests - Full Report
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
app-idinput ofactions/create-github-app-token@v3withclient-idin.github/workflows/create-release.yaml.PUSH_TO_MAIN_APP_IDtoPUSH_TO_MAIN_APP_CLIENT_ID.Why
Input 'app-id' has been deprecated with message: Use 'client-id' instead.(run 24551143115).client-idaligns with the action's current API and avoids a future breaking change when the deprecated input is removed.How
client-idwith a newPUSH_TO_MAIN_APP_CLIENT_IDrepo variable (the App's Client ID from the GitHub App settings page).Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
PUSH_TO_MAIN_APP_CLIENT_IDrepo variable is not populated with the GitHub App's Client ID before the next release run, the Create Release workflow will fail to mint an App token. Action item: set this variable in repo settings prior to merge.Database Migrations
Env Config
PUSH_TO_MAIN_APP_CLIENT_ID(GitHub App Client ID, e.g.Iv23li...). ExistingPUSH_TO_MAIN_APP_IDis no longer referenced.Relevant Docs
client-idinput.Related Issues or PRs
Dependencies Versions
Notes on Testing
workflow_dispatch; verification requires triggering Create Release after the new repo variable is set, and confirming the deprecation warning no longer appears and token generation succeeds.Screenshots
Checklist
I have read and understood the Contribution Guidelines.