Conversation
- Add Disconnect button to the Account modal (was permanently hidden via v-show="!web3") - Fix LOGOUT and LOAD_PROVIDER_FAILURE mutations to reset account to empty object instead of null, preventing null-dereference crashes in templates - Await $auth.logout() before committing LOGOUT to avoid a race condition where account becomes null while isAuthenticated is still true - Remove unused "Connect wallet" button from the account view and clean up dead step data property and watcher Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
frankmeds
reviewed
Apr 23, 2026
frankmeds
previously approved these changes
Apr 23, 2026
Wrap $auth.logout() in try/catch/finally so LOGOUT commit always runs even if the provider rejects, and dispatch a red notification on failure. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…nce-snapshot README The governance portal is scheduled for deprecation and testnet will not be supported. Documents the known limitation that EVM wallet explorer links are hardcoded to zilliqa.blockscout.com (mainnet). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
frankmeds
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This addresses the requests from GZil committee by improving the governance portal account modal with EVM wallet support and fixes for wallet disconnection.
EVM wallet support (
Modal/Account.vue)0xprefix and link to Blockscout; ZilPay addresses continue to use bech32 format and link to ViewBlock.isEVMflag (toggled by a newSET_IS_EVMmutation) so components can distinguish between wallet types, and the flag is cleared on logout.Wallet disconnection (
Modal/Account.vue,web3.ts)v-show="!web3", which was always false) with a functional Disconnect button.logoutstore action:$auth.logout()is now awaited beforeLOGOUTis committed, soisAuthenticatedbecomesfalsebeforeaccountis reset — preventing a cycle where authenticated templates render against a cleared account.LOGOUTandLOAD_PROVIDER_FAILUREmutations now resetaccountto{ base16: '', bech32: '' }(matching the initial state) instead ofnull, eliminating null-dereference crashes in templates that accessweb3.account.base16/web3.account.bech32unconditionally (e.g. Topnav's:keybinding).Testing
Tested locally using docker compose setup.