🧹 Clean up dead timer annotations in StockHistoryRecorder#5
Conversation
🎯 **What:** Removed commented-out `@Schedule` annotations from `myTimer()` and `myTimerDaily()`, and deleted the fully commented-out method `myTimerDailyChannelShedule()`. 💡 **Why:** To address code health by removing dead code, improving readability and maintainability without affecting functionality. The remaining methods are still referenced elsewhere (e.g. `StockHistoryController`) but they don't need commented-out `@Schedule` annotations. ✅ **Verification:** Verified by running the full test suite (`mvn test`) which passed successfully. ✨ **Result:** A cleaner `StockHistoryRecorder` class with less dead code clutter. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…21347 - saveDisposalIssueDraft(): release transient stock holds via userStockController.retiredAllUserStockContainer() before clearBill(), matching the pattern in resetAll() (CodeRabbit #3) - finalizeDisposalIssue(): add billTypeAtomic == PHARMACY_DISPOSAL_ISSUE_PRE and department ownership checks to prevent privilege escalation (Codex #1) - approveDisposalIssue(): same billTypeAtomic + department ownership checks; track deduction failures across the stock loop and surface a warning message when any item had insufficient stock, while preserving the existing tmpQty=0 pattern consistent with settleDisposalIssueBill() (Codex #1, #2) - CodeRabbit #4 (redirect vs preview): dismissed — redirecting to the finalize list after save matches the established pattern in Transfer Receive and Direct Purchase workflows - CodeRabbit #5/#6 (boolean re-entrancy guards): dismissed — existing checkedBy/isRetired/isCompleted state guards are sufficient; no other settle/save methods in the codebase use boolean lock flags Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 participant
🎯 What: Removed commented-out
@Scheduleannotations frommyTimer()andmyTimerDaily(), and deleted the fully commented-out methodmyTimerDailyChannelShedule().💡 Why: To address code health by removing dead code, improving readability and maintainability without affecting functionality. The remaining methods are still referenced elsewhere (e.g.
StockHistoryController) but they don't need commented-out@Scheduleannotations.✅ Verification: Verified by running the full test suite (
mvn test) which passed successfully.✨ Result: A cleaner
StockHistoryRecorderclass with less dead code clutter.PR created automatically by Jules for task 15597754238083567767 started by @manupawickramasinghe