Fix incorrect override of CouplingBetweenObjects for Magento 2#71
Open
ArjenMiedema wants to merge 1 commit into
Open
Conversation
It's not possible to override PHPMD config, so the design ruleset with its default CouplingBetweenObjects set to 13 and the custom override below of 20 resulted in the check being done twice with two different maximum values. By excluding the original value the override from 13 to 20 does work as expected.
CyberSecutor
requested review from
Anve94,
CyberSecutor,
leonhelmus and
rutgerrademaker
CyberSecutor
approved these changes
Apr 10, 2026
|
|
||
| <rule ref="rulesets/design.xml" /> | ||
| <rule ref="rulesets/design.xml"> | ||
| <exclude name="CouplingBetweenObjects"/> |
Contributor
There was a problem hiding this comment.
Suggested change
| <exclude name="CouplingBetweenObjects"/> | |
| <!-- For this rule we have exceptions configured below --> | |
| <exclude name="CouplingBetweenObjects"/> |
Same comment as we use on rulesets/naming.xml to make clear this rule is not disabled but merely overidden
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not possible to override PHPMD config, so the design ruleset with its default CouplingBetweenObjects set to 13 and the custom override below of 20 resulted in the check being done twice with two different maximum values.
By excluding the original value the override from 13 to 20 does work as expected.